chore: Use OS-independent sort for endpoint DSL factory files - #25076
Merged
Conversation
File.compareTo() delegates to the OS filesystem comparator which is case-insensitive on Windows (NTFS) but case-sensitive on Linux/macOS. This causes the generated EndpointBuilders and EndpointBuilderFactory interfaces to have different sort orders depending on the OS, failing CI's uncommitted-changes check when contributors build on Windows. Sort by File.getName() instead, which uses String.compareTo() (ordinal Unicode comparison) and produces identical output on every platform. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
oscerd
approved these changes
Jul 24, 2026
Contributor
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 568 tested, 29 compile-only — current: 70 all testedMaveniverse Scalpel detected 597 affected modules (current approach: 70).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Code on behalf of davsclaus
Summary
EndpointDslMojoto useComparator.comparing(File::getName)instead ofFile.compareTo()when sorting endpoint DSL factory filesFile.compareTo()delegates to the OS filesystem comparator: case-insensitive on Windows (NTFS) but case-sensitive on Linux/macOSEndpointBuilders.javaandEndpointBuilderFactory.javawith a different sort order, failing CI's uncommitted-changes checkRoot cause
File.compareTo()on Windows treatsCMEndpointBuilderFactoryandCaffeineEndpointBuilderFactoryascm...vscaffeine...(case-insensitive), producing a different order than Linux whereCM(uppercase) sorts beforeCa(uppercase then lowercase) by Unicode code point.Fix
Sort by
File.getName()which usesString.compareTo()— ordinal Unicode comparison that produces identical output on every platform and locale.Test plan
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com