CAMEL-24282: Resolve dynamic-URI property placeholders at build time instead of per message - #25198
Draft
oscerd wants to merge 1 commit into
Draft
CAMEL-24282: Resolve dynamic-URI property placeholders at build time instead of per message#25198oscerd wants to merge 1 commit into
oscerd wants to merge 1 commit into
Conversation
…instead of per message Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
oscerd
marked this pull request as draft
July 28, 2026 12:59
Contributor
Author
|
@davsclaus this has been converted to draft because it requires some attention. |
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 548 tested, 28 compile-only — current: 547 all testedMaveniverse Scalpel detected 576 affected modules (current approach: 547).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the dynamic-uri EIPs (
toD,recipientList,routingSlip,dynamicRouter,enrich,pollEnrich) so that Camel property placeholders ({{...}}) are resolved once, at build time, on the endpoint URI written in the route — and not again per message on the evaluated recipient.What
The dynamic-uri EIPs re-resolved property placeholders on the per-message evaluated recipient via:
SendDynamicProcessor.resolveUri()/prepareRecipient()(toD,enrich)ProcessorHelper.prepareRecipient()(recipientList,routingSlip,dynamicRouter,pollEnrich)PollEnricher.resolveUri()(pollEnrich)Placeholders in a dynamic-uri template are fixed at design time and are already resolved at build time (
ToDynamicReifier#createExpressionand the sibling reifiers, plus thedoInitscheme detection). Re-resolving them for every exchange is redundant, and it meant a{{...}}token that only appeared in the evaluated result (for example produced from a message header or body) was unexpectedly re-interpreted as a property placeholder.The per-message paths now normalize the recipient via
NormalizedUri.newNormalizedUri(...)without re-running placeholder resolution. The build-time (doInit) resolution on the staticurifield is unchanged, so{{...}}written in the route template keeps working — the behaviour added in CAMEL-15087 is preserved.getEndpoint(NormalizedEndpointUri)already callsdoGetEndpoint(..., normalized=true, ...)which skips resolution, so nothing re-resolves downstream either.Tests
DynamicEndpointMessagePlaceholderTest— for each EIP (toD,recipientList,routingSlip,enrich,pollEnrich) a{{...}}arriving via a message header is treated as a literal endpoint uri; plus a control asserting a{{...}}written in the static route template is still resolved.ToDynamicPropertyPlaceholderTest,PropertiesComponentEIPRoutingSlipTest, and the recipientList / routingSlip / enricher / pollEnricher tests).mvn clean install -DskipTests) succeeds with no generated-file drift.Docs
Migration note added to the 4.22 upgrade guide (behavioural change for routes that produced a
{{...}}token from message content and relied on it being expanded).Claude Code on behalf of Andrea Cosentino (@oscerd)