Skip to content

CAMEL-24323: Fix MongoDB TLS test-infra cert copy for Testcontainers 2.x - #25284

Merged
davsclaus merged 1 commit into
apache:mainfrom
atiaomar1978-hub:CAMEL-24323-mongodb-ssl-it-fix
Aug 3, 2026
Merged

CAMEL-24323: Fix MongoDB TLS test-infra cert copy for Testcontainers 2.x#25284
davsclaus merged 1 commit into
apache:mainfrom
atiaomar1978-hub:CAMEL-24323-mongodb-ssl-it-fix

Conversation

@atiaomar1978-hub

@atiaomar1978-hub atiaomar1978-hub commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes CAMEL-24323: MongoDbSslConnectionIT fails to start the TLS MongoDB Testcontainer with:

Could not find the file / in container

Root cause: MongoDBLocalContainerTLSService mapped an entire classpath directory via withClasspathResourceMapping. Testcontainers 2.x uses a copy strategy for read-only classpath mappings that breaks on directory mounts in CI.

Fix: Copy TLS cert files individually with MountableFile.forClasspathResource + withCopyFileToContainer (same approach as other Camel test-infra services, e.g. Kafka JAAS config).

Changes

  • MongoDBLocalContainerTLSService — per-file cert copy for server.pem and ca.pem
  • MongoDBLocalContainerTLSServiceTest — classpath resource + MountableFile + TLS command config coverage (3 tests)
  • MongoDbSslConnectionIT — added testInsertAndCountOverTls round-trip assertion

Test plan

  • mvn test -pl test-infra/camel-test-infra-mongodb -Dtest=MongoDBLocalContainerTLSServiceTest
  • mvn test -pl components/camel-mongodb -am -Dtest=MongoDbSslConnectionIT (Docker)

AI-generated PR description on behalf of atiaomar1978-hub

Made with Cursor

Omar Atie @cursoragent Omar Atie
CAMEL-24323: Fix MongoDB TLS test-infra cert copy for Testcontainers 2.x
42460fa 
Replace directory classpath mapping with per-file withCopyFileToContainer
calls so MongoDbSslConnectionIT can start the TLS mongod container.
Add MongoDBLocalContainerTLSServiceTest and an insert+count TLS IT case.

Co-authored-by: Cursor <cursoragent@cursor.com>
@atiaomar1978-hub

atiaomar1978-hub commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

AI-generated comment on behalf of atiaomar1978-hub

Investigation

CI failure in CAMEL-24323 showed Testcontainers failing during CopyArchiveToContainer with Could not find the file / in container when starting mirror.gcr.io/mongo:7.0.31-jammy.

The TLS service introduced in CAMEL-23182 (#21951) used:

.withClasspathResourceMapping(CERT_RESOURCE_PATH, "/etc/mongodb/ssl", BindMode.READ_ONLY)

On Testcontainers 2.x (Camel uses 2.0.5), read-only classpath directory mappings use a copy strategy that does not reliably mount directory contents — individual file copy is the portable fix.

Fix

Switched to per-file copy (Kafka JAAS pattern):

.withCopyFileToContainer(MountableFile.forClasspathResource(SERVER_CERT_RESOURCE), ...)
.withCopyFileToContainer(MountableFile.forClasspathResource(CA_CERT_RESOURCE), ...)

Tests (all green locally)

Suite Tests
MongoDBLocalContainerTLSServiceTest 3/3
MongoDbSslConnectionIT 3/3 (Docker)

Ready for review once CI completes.

gnodet
gnodet reviewed Aug 2, 2026
View reviewed changes

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core fix is correct — switching from withClasspathResourceMapping directory mount to per-file withCopyFileToContainer + MountableFile.forClasspathResource for Testcontainers 2.x compatibility. This follows the same pattern used by other test-infra services (Kafka JAAS, TensorFlow Serving).

Highlights:

  • The extracted constants (CONTAINER_SSL_DIR, SERVER_CERT_RESOURCE, CA_CERT_RESOURCE) improve readability.
  • The new unit test verifies TLS command configuration and resource resolution.

Minor notes (non-blocking):

  • MongoDbSslConnectionIT class still has the public modifier — per JUnit 5 conventions it should be package-private (since you're already modifying the file).
  • The descriptive assertion message was removed from assertEquals — consider keeping or using AssertJ's as() for better failure diagnostics.
  • Other test-infra services still use withClasspathResourceMapping with directory mounts (NATS TLS, Infinispan, etc.) — they may need similar migration.
  • CI should be verified once checks run on this branch.

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of @gnodet

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • components/camel-mongodb
  • test-infra/camel-test-infra-mongodb
🔬 Scalpel shadow comparison — Scalpel: 12 tested, 29 compile-only — current: 12 all tested

Maveniverse Scalpel detected 41 affected modules (current approach: 12).

⚠️ Modules only in Scalpel (29)
  • apache-camel
  • camel-allcomponents
  • camel-catalog
  • camel-catalog-console
  • camel-catalog-lucene
  • camel-catalog-maven
  • camel-catalog-suggest
  • camel-componentdsl
  • camel-csimple-maven-plugin
  • camel-endpointdsl
  • camel-endpointdsl-support
  • camel-itest
  • camel-jbang-core
  • camel-jbang-it
  • camel-jbang-main
  • camel-jbang-plugin-edit
  • camel-jbang-plugin-generate
  • camel-jbang-plugin-kubernetes
  • camel-jbang-plugin-test
  • camel-kamelet-main
  • camel-launcher
  • camel-report-maven-plugin
  • camel-route-parser
  • camel-yaml-dsl
  • camel-yaml-dsl-deserializers
  • camel-yaml-dsl-maven-plugin
  • coverage
  • docs
  • dummy-component

Skip-tests mode would test 12 modules (2 direct + 10 downstream), skip tests for 29 (generated code, meta-modules)

Modules Scalpel would test (12)
  • camel-jbang-mcp
  • camel-jbang-plugin-mcp
  • camel-jbang-plugin-route-parser
  • camel-jbang-plugin-tui
  • camel-jbang-plugin-validate
  • camel-launcher-container
  • camel-mongodb
  • camel-mongodb-gridfs
  • camel-test-infra-all
  • camel-test-infra-mongodb
  • camel-yaml-dsl-validator
  • camel-yaml-dsl-validator-maven-plugin
Modules with tests skipped (29)
  • apache-camel
  • camel-allcomponents
  • camel-catalog
  • camel-catalog-console
  • camel-catalog-lucene
  • camel-catalog-maven
  • camel-catalog-suggest
  • camel-componentdsl
  • camel-csimple-maven-plugin
  • camel-endpointdsl
  • camel-endpointdsl-support
  • camel-itest
  • camel-jbang-core
  • camel-jbang-it
  • camel-jbang-main
  • camel-jbang-plugin-edit
  • camel-jbang-plugin-generate
  • camel-jbang-plugin-kubernetes
  • camel-jbang-plugin-test
  • camel-kamelet-main
  • camel-launcher
  • camel-report-maven-plugin
  • camel-route-parser
  • camel-yaml-dsl
  • camel-yaml-dsl-deserializers
  • camel-yaml-dsl-maven-plugin
  • coverage
  • docs
  • dummy-component

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

All tested modules (41 modules)
  • Camel :: All Components Sync point
  • Camel :: Assembly
  • Camel :: Catalog :: CSimple Maven Plugin (deprecated)
  • Camel :: Catalog :: Camel Catalog
  • Camel :: Catalog :: Camel Report Maven Plugin
  • Camel :: Catalog :: Camel Route Parser
  • Camel :: Catalog :: Console
  • Camel :: Catalog :: Dummy Component
  • Camel :: Catalog :: Lucene (deprecated)
  • Camel :: Catalog :: Maven
  • Camel :: Catalog :: Suggest
  • Camel :: Component DSL
  • Camel :: Coverage
  • Camel :: Docs
  • Camel :: Endpoint DSL
  • Camel :: Endpoint DSL :: Support
  • Camel :: Integration Tests
  • Camel :: JBang :: Core
  • Camel :: JBang :: Integration tests
  • Camel :: JBang :: MCP
  • Camel :: JBang :: Main
  • Camel :: JBang :: Plugin :: Edit
  • Camel :: JBang :: Plugin :: Generate
  • Camel :: JBang :: Plugin :: Kubernetes
  • Camel :: JBang :: Plugin :: MCP
  • Camel :: JBang :: Plugin :: Route Parser
  • Camel :: JBang :: Plugin :: TUI
  • Camel :: JBang :: Plugin :: Testing
  • Camel :: JBang :: Plugin :: Validate
  • Camel :: Kamelet Main
  • Camel :: Launcher
  • Camel :: Launcher :: Container
  • Camel :: MongoDB
  • Camel :: MongoDB GridFS
  • Camel :: Test Infra :: All test services
  • Camel :: Test Infra :: MongoDB
  • Camel :: YAML DSL
  • Camel :: YAML DSL :: Deserializers
  • Camel :: YAML DSL :: Maven Plugins
  • Camel :: YAML DSL :: Validator
  • Camel :: YAML DSL :: Validator Maven Plugin

⚙️ View full build and test results

@davsclaus davsclaus added this to the 4.22.0 milestone Aug 3, 2026
@davsclaus davsclaus added the task label Aug 3, 2026
@davsclaus
davsclaus merged commit 35c78a0 into apache:main Aug 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnodet gnodet gnodet left review comments
@davsclaus davsclaus davsclaus approved these changes

Assignees

@atiaomar1978-hub atiaomar1978-hub

Labels

components task test-infra

Projects

None yet

Milestone

4.22.0

Development

Successfully merging this pull request may close these issues.

3 participants

@atiaomar1978-hub @gnodet @davsclaus