Skip to content

CAMEL-24326: camel-aws-config - throw when pojoRequest=true and the body is the wrong type - #25305

Merged
oscerd merged 1 commit into
apache:mainfrom
oscerd:a1/CAMEL-24326-aws-config
Aug 3, 2026
Merged

CAMEL-24326: camel-aws-config - throw when pojoRequest=true and the body is the wrong type#25305
oscerd merged 1 commit into
apache:mainfrom
oscerd:a1/CAMEL-24326-aws-config

Conversation

@oscerd

@oscerd oscerd commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Child of CAMEL-24261 (completing CAMEL-23462 across the AWS2 producers).

Problem

With pojoRequest=true, AWSConfigProducer's five operations (putConfigRule,
removeConfigRule, describeRuleCompliance, putConformancePack,
removeConformancePack) only acted when the body was the matching request type;
any other body fell through the instanceof with no else, so no AWS call was
made, no response was set, and the original body was returned with no error.

Fix

Each branch now throws IllegalArgumentException naming the required request
type, e.g. "putConformancePack operation requires PutConformancePackRequest in POJO mode".

Test

camel-aws-config has no producer route/mock harness, so this is covered by a new
Mockito parameterized unit test that mocks the endpoint + client, sends a
wrong-typed body with pojoRequest=true, and asserts each IllegalArgumentException.
Verified to fail (silent no-op) before the fix. Region-free — no localstack or
real AWS.

Docs / backport

The shared 4.22 upgrade-guide entry was added with CAMEL-24263. Main only, matching
the CAMEL-23462 precedent (behaviour change, shipped in a minor, not backported).


Claude Code on behalf of oscerd

…ody is the wrong type

Child of CAMEL-24261. AWSConfigProducer's five operations (putConfigRule,
removeConfigRule, describeRuleCompliance, putConformancePack,
removeConformancePack) only acted when the body was the matching request type
under pojoRequest=true; any other body silently fell through with no AWS call and
no error. Add the missing else that throws IllegalArgumentException naming the
required type, consistent with CAMEL-23462.

Covered by a new Mockito-based parameterized unit test (the module has no producer
route harness); verified to fail (silent no-op) before the fix. The shared 4.22
upgrade-guide entry was added with CAMEL-24263.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
@oscerd oscerd added the bug Something isn't working label Aug 3, 2026
@oscerd oscerd added this to the 4.22.0 milestone Aug 3, 2026
@oscerd
oscerd requested review from Croway and davsclaus August 3, 2026 07:44

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review was generated by Claude Code, an AI assistant, on behalf of @gnodet.

Clean and well-structured PR. The validation logic, exception type, and error message format are all consistent with the precedent set by BedrockProducer under the parent issue CAMEL-24261.

What I verified:

  • All 5 operation methods (putConfigRule, removeConfigRule, describeRuleCompliance, putConformancePack, removeConformancePack) now have else branches that throw IllegalArgumentException when pojoRequest=true and the body is not the expected SDK request type.
  • IllegalArgumentException is already the validation exception used throughout AWSConfigProducer (lines 70, 121, 165, 235, 250, 287), so this is consistent.
  • Error message format (<operation> operation requires <SdkType> in POJO mode) matches the bedrock component.
  • The test uses package-private visibility (JUnit 5 convention), AssertJ assertions (project convention), and a parameterized @CsvSource covering all 5 operations.
  • The lightweight Mockito approach (mock endpoint + client, call process() directly) is appropriate here -- no CamelContext startup overhead needed since the exception is thrown before any AWS client call.
  • assertj-core is correctly added without a version (managed by the parent POM).

No issues found. LGTM.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • components/camel-aws/camel-aws-config

🔬 Scalpel shadow comparison — Scalpel: 9 tested, 29 compile-only — current: 9 all tested

Maveniverse Scalpel detected 38 affected modules (current approach: 9).

⚠️ Modules only in Scalpel (29)
  • apache-camel
  • camel-allcomponents
  • camel-catalog
  • camel-catalog-console
  • camel-catalog-lucene
  • camel-catalog-maven
  • camel-catalog-suggest
  • camel-componentdsl
  • camel-csimple-maven-plugin
  • camel-endpointdsl
  • camel-endpointdsl-support
  • camel-itest
  • camel-jbang-core
  • camel-jbang-it
  • camel-jbang-main
  • camel-jbang-plugin-edit
  • camel-jbang-plugin-generate
  • camel-jbang-plugin-kubernetes
  • camel-jbang-plugin-test
  • camel-kamelet-main
  • camel-launcher
  • camel-report-maven-plugin
  • camel-route-parser
  • camel-yaml-dsl
  • camel-yaml-dsl-deserializers
  • camel-yaml-dsl-maven-plugin
  • coverage
  • docs
  • dummy-component

Skip-tests mode would test 9 modules (1 direct + 8 downstream), skip tests for 29 (generated code, meta-modules)

Modules Scalpel would test (9)
  • camel-aws-config
  • camel-jbang-mcp
  • camel-jbang-plugin-mcp
  • camel-jbang-plugin-route-parser
  • camel-jbang-plugin-tui
  • camel-jbang-plugin-validate
  • camel-launcher-container
  • camel-yaml-dsl-validator
  • camel-yaml-dsl-validator-maven-plugin
Modules with tests skipped (29)
  • apache-camel
  • camel-allcomponents
  • camel-catalog
  • camel-catalog-console
  • camel-catalog-lucene
  • camel-catalog-maven
  • camel-catalog-suggest
  • camel-componentdsl
  • camel-csimple-maven-plugin
  • camel-endpointdsl
  • camel-endpointdsl-support
  • camel-itest
  • camel-jbang-core
  • camel-jbang-it
  • camel-jbang-main
  • camel-jbang-plugin-edit
  • camel-jbang-plugin-generate
  • camel-jbang-plugin-kubernetes
  • camel-jbang-plugin-test
  • camel-kamelet-main
  • camel-launcher
  • camel-report-maven-plugin
  • camel-route-parser
  • camel-yaml-dsl
  • camel-yaml-dsl-deserializers
  • camel-yaml-dsl-maven-plugin
  • coverage
  • docs
  • dummy-component

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

All tested modules (38 modules)
  • Camel :: AWS Config
  • Camel :: All Components Sync point
  • Camel :: Assembly
  • Camel :: Catalog :: CSimple Maven Plugin (deprecated)
  • Camel :: Catalog :: Camel Catalog
  • Camel :: Catalog :: Camel Report Maven Plugin
  • Camel :: Catalog :: Camel Route Parser
  • Camel :: Catalog :: Console
  • Camel :: Catalog :: Dummy Component
  • Camel :: Catalog :: Lucene (deprecated)
  • Camel :: Catalog :: Maven
  • Camel :: Catalog :: Suggest
  • Camel :: Component DSL
  • Camel :: Coverage
  • Camel :: Docs
  • Camel :: Endpoint DSL
  • Camel :: Endpoint DSL :: Support
  • Camel :: Integration Tests
  • Camel :: JBang :: Core
  • Camel :: JBang :: Integration tests
  • Camel :: JBang :: MCP
  • Camel :: JBang :: Main
  • Camel :: JBang :: Plugin :: Edit
  • Camel :: JBang :: Plugin :: Generate
  • Camel :: JBang :: Plugin :: Kubernetes
  • Camel :: JBang :: Plugin :: MCP
  • Camel :: JBang :: Plugin :: Route Parser
  • Camel :: JBang :: Plugin :: TUI
  • Camel :: JBang :: Plugin :: Testing
  • Camel :: JBang :: Plugin :: Validate
  • Camel :: Kamelet Main
  • Camel :: Launcher
  • Camel :: Launcher :: Container
  • Camel :: YAML DSL
  • Camel :: YAML DSL :: Deserializers
  • Camel :: YAML DSL :: Maven Plugins
  • Camel :: YAML DSL :: Validator
  • Camel :: YAML DSL :: Validator Maven Plugin

⚙️ View full build and test results

@oscerd oscerd self-assigned this Aug 3, 2026
@oscerd
oscerd merged commit 90eec63 into apache:main Aug 3, 2026
5 checks passed
@oscerd
oscerd deleted the a1/CAMEL-24326-aws-config branch August 3, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working components components-aws

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants