Skip to content

ci: fix CamelJfrDevConsoleTest for the registered -> runtimeEvents status rename - #25327

Merged
oscerd merged 1 commit into
apache:mainfrom
oscerd:ci-issue/camel-jfr-devconsole-runtimeevents-rename
Aug 4, 2026
Merged

ci: fix CamelJfrDevConsoleTest for the registered -> runtimeEvents status rename#25327
oscerd merged 1 commit into
apache:mainfrom
oscerd:ci-issue/camel-jfr-devconsole-runtimeevents-rename

Conversation

@oscerd

@oscerd oscerd commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Problem

CamelJfrDevConsoleTest fails deterministically on main — 3 of its status tests (statusReportsNotRegisteredByDefault, statusReportsRegisteredWhenRuntimeInstrumentationEnabled, jsonStatusAndToggleReflectLiveState).

CamelJfrDevConsole renamed its status field from registered to runtimeEvents — both the TEXT line (sb.append("runtimeEvents: ")…) and the JSON key (root.put("runtimeEvents", …)), keeping the same isInstrumentationRegistered() value — but the test still asserted the old registered name (TEXT contains("registered: …") and JSON getBoolean("registered"), which now returns null).

Because camel-jfr is transitively pulled into the scalpel build of any PR that touches a core module, this was failing the CI of unrelated PRs.

Fix

Update the three assertions to the new runtimeEvents field name. Test-only, no production change. CamelJfrDevConsoleTest17 tests pass.

Claude Code on behalf of Andrea Cosentino (@oscerd).

🤖 Generated with Claude Code

…atus rename

CamelJfrDevConsole renamed its status field from "registered" to "runtimeEvents"
(both the TEXT line and the JSON key, same isInstrumentationRegistered() value),
but CamelJfrDevConsoleTest still asserted the old name, so its three status tests
failed deterministically on main. Because camel-jfr is pulled into the scalpel
build of any core-touching PR, this was failing unrelated PRs' CI. Update the
assertions to the new field name. 17 tests pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
@oscerd
oscerd requested review from davsclaus and gnodet August 4, 2026 14:54
@oscerd oscerd added the core label Aug 4, 2026
@oscerd oscerd self-assigned this Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions github-actions Bot added components and removed core labels Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • components/camel-jfr

🔬 Scalpel shadow comparison — Scalpel: 1 tested, 0 compile-only — current: 9 all tested

Maveniverse Scalpel detected 1 affected modules (current approach: 9).

Modules only in current approach (8)
  • camel-jbang-mcp
  • camel-jbang-plugin-mcp
  • camel-jbang-plugin-route-parser
  • camel-jbang-plugin-tui
  • camel-jbang-plugin-validate
  • camel-launcher-container
  • camel-yaml-dsl-validator
  • camel-yaml-dsl-validator-maven-plugin

Skip-tests mode would test 1 modules (1 direct + 0 downstream), skip tests for 0 (generated code, meta-modules)

Modules Scalpel would test (1)
  • camel-jfr

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

All tested modules (9 modules)
  • Camel :: JBang :: MCP
  • Camel :: JBang :: Plugin :: MCP
  • Camel :: JBang :: Plugin :: Route Parser
  • Camel :: JBang :: Plugin :: TUI
  • Camel :: JBang :: Plugin :: Validate
  • Camel :: Java Flight Recorder
  • Camel :: Launcher :: Container
  • Camel :: YAML DSL :: Validator
  • Camel :: YAML DSL :: Validator Maven Plugin

⚙️ View full build and test results

@oscerd oscerd added this to the 4.22.0 milestone Aug 4, 2026
@oscerd
oscerd merged commit 6597f28 into apache:main Aug 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants