ci: fix CamelJfrDevConsoleTest for the registered -> runtimeEvents status rename - #25327
Merged
oscerd merged 1 commit intoAug 4, 2026
Conversation
…atus rename CamelJfrDevConsole renamed its status field from "registered" to "runtimeEvents" (both the TEXT line and the JSON key, same isInstrumentationRegistered() value), but CamelJfrDevConsoleTest still asserted the old name, so its three status tests failed deterministically on main. Because camel-jfr is pulled into the scalpel build of any core-touching PR, this was failing unrelated PRs' CI. Update the assertions to the new field name. 17 tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
davsclaus
approved these changes
Aug 4, 2026
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 1 tested, 0 compile-only — current: 9 all testedMaveniverse Scalpel detected 1 affected modules (current approach: 9). Modules only in current approach (8)
Skip-tests mode would test 1 modules (1 direct + 0 downstream), skip tests for 0 (generated code, meta-modules) Modules Scalpel would test (1)
All tested modules (9 modules)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CamelJfrDevConsoleTestfails deterministically onmain— 3 of its status tests (statusReportsNotRegisteredByDefault,statusReportsRegisteredWhenRuntimeInstrumentationEnabled,jsonStatusAndToggleReflectLiveState).CamelJfrDevConsolerenamed its status field fromregisteredtoruntimeEvents— both the TEXT line (sb.append("runtimeEvents: ")…) and the JSON key (root.put("runtimeEvents", …)), keeping the sameisInstrumentationRegistered()value — but the test still asserted the oldregisteredname (TEXTcontains("registered: …")and JSONgetBoolean("registered"), which now returns null).Because
camel-jfris transitively pulled into the scalpel build of any PR that touches a core module, this was failing the CI of unrelated PRs.Fix
Update the three assertions to the new
runtimeEventsfield name. Test-only, no production change.CamelJfrDevConsoleTest— 17 tests pass.Claude Code on behalf of Andrea Cosentino (@oscerd).
🤖 Generated with Claude Code