[backport camel-4.18.x] CAMEL-24357: camel-aws2-s3-vectors - consumer returns no results (topK=0), ignores delay, loses vectors - #25377
Merged
Conversation
…ors delay, and no longer loses vectors on failure The aws2-s3-vectors consumer had several defects rooted in consumer options that shadow the base scheduled-poll options: - poll() sent topK(Math.min(getMaxMessagesPerPoll(), topK)) where the base maxMessagesPerPoll field was never wired (default 0), so topK(0) was sent and AWS returned nothing. maxMessagesPerPoll is now wired from the configuration in createConsumer and topK treats a non-positive cap as "unlimited". - the delay option bound to a configuration field the consumer never read; it is now propagated to the consumer's scheduler. - vectors were marked processed before routing, so a failed exchange was skipped forever; the de-dup set is now only populated when deleteAfterRead=false and an id is dropped again on failure so the vector can be retried on a later poll. Adds AWS2S3VectorsConsumerTest covering the topK and delay fixes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
davsclaus
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #25369 to camel-4.18.x.
The aws2-s3-vectors consumer sent
topK(0)on every poll (the basemaxMessagesPerPollwas never wired, soMath.min(0, topK) = 0) and delivered nothing; thedelayoption was a dead shadow field; and vectors were marked processed before routing, so a failed exchange was skipped forever. The consumer now wiresmaxMessagesPerPoll, sends a validtopK (>= 1), propagatesdelayto the scheduler, and only marks a vector processed on success (dropping it on failure for retry).Adds
AWS2S3VectorsConsumerTest; s3-vectors tests green on this branch.Claude Code on behalf of oscerd