CAMEL-24363: camel-aws - iam doStop, eks catalog defaultValue, parameter-store value header - #25389
Conversation
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
There are uncommitted changes |
…e, parameter-store value header Three small independent fixes found during the camel-aws review: - IAM2Endpoint.doStop() now calls super.doStop(). Every other aws2 endpoint (including the paired KMS2Endpoint) calls it; IAM was the only one skipping the base ScheduledPollEndpoint/DefaultEndpoint stop logic. - EKS2Configuration.profileCredentialsName had a copy-pasted @UriParam(defaultValue = "false") on a String option, which polluted the generated catalog with a misleading default. It now matches ECS (@UriParam(label = "security")) and the catalog is regenerated. - ParameterStoreProducer.putParameter now honors the documented CamelAwsParameterStoreValue header when present (falling back to the message body), so the advertised producer header is no longer a no-op. Adds a test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
4ffd876 to
3bda844
Compare
davsclaus
left a comment
There was a problem hiding this comment.
Claude Code on behalf of davsclaus
The @UriParam annotation change on profileCredentialsName in EKS2Configuration.java requires regenerating the following files:
catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/aws2-eks.jsondsl/camel-componentdsl/src/generated/java/org/apache/camel/builder/component/dsl/Aws2EksComponentBuilderFactory.javadsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/EKS2EndpointBuilderFactory.java
To regenerate, run (in order):
cd components/camel-aws/camel-aws2-eks && mvn install -DskipTests
cd catalog && mvn install -DskipTests
cd dsl/camel-endpointdsl && mvn install -DskipTests
cd dsl/camel-componentdsl && mvn install -DskipTests
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Three small, independent fixes found during the camel-aws review.
1.
IAM2Endpoint.doStop()did not callsuper.doStop()— it closed the IAM client but skipped the baseScheduledPollEndpoint/DefaultEndpointstop logic. Every other aws2 endpoint (including the pairedKMS2Endpoint) calls it. Fixed.2. eks
profileCredentialsNamehad a bogus catalog default — theStringoption was annotated@UriParam(defaultValue = "false")(copy-pasted from the adjacent boolean provider flags), publishing a misleading"defaultValue": "false"for a profile-name string. Now matches ECS (@UriParam(label = "security")); catalog regenerated.3. parameter-store
CamelAwsParameterStoreValueheader was advertised but never read —putParameteralways took the value from the message body, so the documented producer header was a no-op. It now honors the header when present (falling back to the body). AddsParameterStoreProducerTest.putParameterHonorsTheValueHeader.All three are low severity. Full 683-module reactor build is green; the new parameter-store test passes. Targeting main (4.22.0).
Claude Code on behalf of oscerd