Skip to content

CAMEL-24363: camel-aws - iam doStop, eks catalog defaultValue, parameter-store value header - #25389

Merged
davsclaus merged 2 commits into
apache:mainfrom
oscerd:fix/CAMEL-24363
Aug 6, 2026
Merged

CAMEL-24363: camel-aws - iam doStop, eks catalog defaultValue, parameter-store value header#25389
davsclaus merged 2 commits into
apache:mainfrom
oscerd:fix/CAMEL-24363

Conversation

@oscerd

@oscerd oscerd commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Three small, independent fixes found during the camel-aws review.

1. IAM2Endpoint.doStop() did not call super.doStop() — it closed the IAM client but skipped the base ScheduledPollEndpoint/DefaultEndpoint stop logic. Every other aws2 endpoint (including the paired KMS2Endpoint) calls it. Fixed.

2. eks profileCredentialsName had a bogus catalog default — the String option was annotated @UriParam(defaultValue = "false") (copy-pasted from the adjacent boolean provider flags), publishing a misleading "defaultValue": "false" for a profile-name string. Now matches ECS (@UriParam(label = "security")); catalog regenerated.

3. parameter-store CamelAwsParameterStoreValue header was advertised but never readputParameter always took the value from the message body, so the documented producer header was a no-op. It now honors the header when present (falling back to the body). Adds ParameterStoreProducerTest.putParameterHonorsTheValueHeader.

All three are low severity. Full 683-module reactor build is green; the new parameter-store test passes. Targeting main (4.22.0).

Claude Code on behalf of oscerd

@oscerd
oscerd requested review from Croway and davsclaus August 6, 2026 13:30
@oscerd oscerd added the bug Something isn't working label Aug 6, 2026
@oscerd oscerd added this to the 4.22.0 milestone Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@davsclaus

Copy link
Copy Markdown
Contributor

There are uncommitted changes
HEAD detached at pull/25389/merge
Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git restore ..." to discard changes in working directory)
modified: catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/aws2-eks.json
modified: dsl/camel-componentdsl/src/generated/java/org/apache/camel/builder/component/dsl/Aws2EksComponentBuilderFactory.java
modified: dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/EKS2EndpointBuilderFactory.java

…e, parameter-store value header

Three small independent fixes found during the camel-aws review:

- IAM2Endpoint.doStop() now calls super.doStop(). Every other aws2 endpoint
  (including the paired KMS2Endpoint) calls it; IAM was the only one skipping
  the base ScheduledPollEndpoint/DefaultEndpoint stop logic.
- EKS2Configuration.profileCredentialsName had a copy-pasted
  @UriParam(defaultValue = "false") on a String option, which polluted the
  generated catalog with a misleading default. It now matches ECS
  (@UriParam(label = "security")) and the catalog is regenerated.
- ParameterStoreProducer.putParameter now honors the documented
  CamelAwsParameterStoreValue header when present (falling back to the message
  body), so the advertised producer header is no longer a no-op. Adds a test.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Andrea Cosentino <ancosen@gmail.com>

@davsclaus davsclaus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code on behalf of davsclaus

The @UriParam annotation change on profileCredentialsName in EKS2Configuration.java requires regenerating the following files:

  • catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/aws2-eks.json
  • dsl/camel-componentdsl/src/generated/java/org/apache/camel/builder/component/dsl/Aws2EksComponentBuilderFactory.java
  • dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/EKS2EndpointBuilderFactory.java

To regenerate, run (in order):

cd components/camel-aws/camel-aws2-eks && mvn install -DskipTests
cd catalog && mvn install -DskipTests
cd dsl/camel-endpointdsl && mvn install -DskipTests
cd dsl/camel-componentdsl && mvn install -DskipTests

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
@davsclaus
davsclaus merged commit 5035a68 into apache:main Aug 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working components components-aws

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants