CAMEL-24372: camel-tui YAML editor undo/redo, block ops, word nav, find in edit - #25407
Closed
atiaomar1978-hub wants to merge 2 commits into
Closed
CAMEL-24372: camel-tui YAML editor undo/redo, block ops, word nav, find in edit#25407atiaomar1978-hub wants to merge 2 commits into
atiaomar1978-hub wants to merge 2 commits into
Conversation
…edit Add SourceEditHistory, YamlBlockEditor, and SourceEditorNavigation helpers and wire them into SourceViewer edit mode for undo/redo (Ctrl+Z/Y), YAML block move/duplicate/delete (Alt+arrows, Ctrl+D/K), comment toggle (Ctrl+/), word navigation/delete, smart Home, and find while editing. Includes comprehensive unit and integration tests for the new editor ops. Co-authored-by: Omar Atie <atiaomar1978-hub@users.noreply.github.com>
Use isKey(KeyCode.*) with modifiers for Alt/Ctrl chords (tamboui only matches unmodified keys on isUp/isLeft/isDelete*). Align find n/N with view mode, jump to nearest match on confirm, clear find on Esc, route paste to find input, and fix moveBlockUp cursor placement. Co-authored-by: Omar Atie <atiaomar1978-hub@users.noreply.github.com>
Contributor
Author
Bugbot reviewReviewed `cursor/CAMEL-24372-tui-yaml-editor-c587` vs `main`. Verified fixes
Remaining suggestions (non-blocking)
AI-generated review comment on behalf of atiaomar1978-hub. |
Contributor
Author
Grok code reviewVerdict: Approve with minor follow-ups CAMEL-24372 scope is implemented with solid helper separation and good test coverage. Key tamboui KeyEvent pitfalls were addressed before opening this upstream PR. Strengths
Minor follow-ups (optional)
Test coverage summary
Ready for human committer review. AI-generated review comment on behalf of atiaomar1978-hub. |
atiaomar1978-hub
marked this pull request as ready for review
August 8, 2026 03:31
Contributor
Author
|
Closing to reopen with correctly named feature/ branch per contributor workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements CAMEL-24372: enhanced plain-text edit mode in the camel-jbang TUI source viewer for YAML (and other local files).
Editor features
#comment on blockImplementation
SourceEditHistory— snapshot-based undo/redo stack (max 100)YamlBlockEditor— YAML list-item block detection and move/duplicate/delete/commentSourceEditorNavigation— word boundaries and smart homeSourceViewer— key bindings, footer hints, find-while-editing viaSearchHighlighterSearchHighlighter— edit-mode find input/navigation,closeInputOnly(),jumpToNearestMatchon confirmReview follow-ups addressed
isKey(KeyCode.*)instead ofisUp()/isLeft()/isDelete*()with Ctrl/Alt)n/Nnavigation aligned with view mode; Esc clears find; paste routes to find input; jump to nearest match after confirmmoveBlockUpcursor lands on the moved block after swapTests
YamlBlockEditorTest— block find/move/duplicate/delete/commentSourceEditHistoryTest— undo/redo stack behaviorSourceEditorNavigationTest— word nav and smart homeSourceViewerEditorOpsTest— integration viaSourceVieweredit modeAI-generated PR description on behalf of atiaomar1978-hub.