CAMEL-24373: Add camel-alibaba MVP (common, OSS, MNS) — phase 1 - #25433
Merged
davsclaus merged 12 commits intoAug 12, 2026
Conversation
Contributor
Author
Bugbot / Grok Review — CAMEL-24373 Phase 1 MVPVerdict: Approve (fixes applied before upstream PR) Findings addressed
Tests (33 passing)./mvnw -pl components/camel-alibaba/camel-alibaba-common,components/camel-alibaba/camel-alibaba-oss,components/camel-alibaba/camel-alibaba-mns testFollow-ups (non-blocking)
AI-generated review on behalf of atiaomar1978-hub |
atiaomar1978-hub
marked this pull request as ready for review
August 10, 2026 18:04
davsclaus
requested changes
Aug 11, 2026
davsclaus
left a comment
davsclaus
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this contribution, @atiaomar1978-hub — great to see Alibaba Cloud support coming to Camel! The component structure is well organized and follows Camel patterns nicely. I have a few items that need attention before this can be merged.
Blocking
- Unresolved merge conflict in
parent/pom.xml— the branch needs to be rebased on currentmainto resolve the conflict markers.
Significant
camel-alibaba-commondepends onalibabacloud-oss-v2— the common module pulls in the OSS SDK, which meanscamel-alibaba-mnstransitively gets the entire OSS SDK even though it doesn't use it.AlibabaClientBuilderUtil(which creates OSS clients) should live incamel-alibaba-oss; the common module should only contain truly shared code.OSSEndpoint.initClient()doesn't cache the created client — the method creates a new client but never assigns it tothis.ossClient, sogetOssClient()always returns null and clients may be leaked.AlibabaClientRegistryis unused — defined in common but never referenced by OSS or MNS.
Moderate
- OSS headers
Content-LengthandContent-Typecollide with standard HTTP headers — Camel convention uses theCamelXxxprefix for component headers (the other headers in the same class follow this correctly). OSSComponent.createEndpoint()missing@Override— the MNS component has it, this one doesn't.
Minor
- OSS producer serializes all SDK responses to JSON strings via Gson, which is unusual — Camel components typically set structured response metadata in headers/properties.
- Inconsistent switch style: MNS uses enhanced switch (
->), OSS uses traditional (case: break).
Questions
- Alibaba MNS is deprecated by Alibaba Cloud in favor of RocketMQ. Should the documentation note this?
OSSClientappears closeable but neither endpoint nor producer/consumer callsclose()on shutdown.
Note: This review covers project rules and conventions. It does not replace specialized tools such as CodeRabbit, Sourcery, or SonarCloud for deeper static analysis.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
cursor
Bot
force-pushed
the
feature/CAMEL-24373-alibaba-phase1
branch
from
August 11, 2026 06:21
3a8d899 to
1ddf05a
Compare
Contributor
Author
Review feedback addressed (@davsclaus)Thanks for the thorough review! The following items have been fixed in commits
Tests (33 passing)./mvnw -pl components/camel-alibaba/camel-alibaba-common,components/camel-alibaba/camel-alibaba-oss,components/camel-alibaba/camel-alibaba-mns testFollow-ups (non-blocking, unchanged)
Bugbot / Grok ReviewVerdict: Approve — prior blocking/significant review items addressed. Remaining non-blocking observations:
AI-generated comment on behalf of atiaomar1978-hub |
Contributor
Author
Bugbot / Grok follow-up (commit
|
| Severity | Issue | Fix |
|---|---|---|
| Significant | OSS credential resolution ignored endpoint AK/SK when empty ServiceKeys bean present |
Match MNS/Huawei pattern: prefer endpoint params, then non-empty ServiceKeys |
| Significant | MNS client never closed on shutdown | Added doStop() + autowiredMnsClient flag (mirrors OSS) |
| Moderate | listObjects ignored maxKeys and scanned entire bucket |
Cap collected results at maxKeys |
Bugbot verdict: Approve for phase 1 MVP after these commits.
Grok verdict: Request changes resolved — remaining items are non-blocking (Gson JSON bodies, OSS doc property vs header wording, optional integration tests).
All 33 unit tests still passing locally.
AI-generated comment on behalf of atiaomar1978-hub
Contributor
|
okay so main is now ready for 4.23.0-SNAPSHOT and this PR needs to be rebased on top and update its versions |
cursor
Bot
force-pushed
the
feature/CAMEL-24373-alibaba-phase1
branch
from
August 11, 2026 16:42
ab358f2 to
9d890ac
Compare
Contributor
Author
Rebased on main for 4.23.0-SNAPSHOT (@davsclaus)Addressed the latest review comment:
TestsAll alibaba module unit tests passing locally: ./mvnw -pl components/camel-alibaba/camel-alibaba-common,components/camel-alibaba/camel-alibaba-oss,components/camel-alibaba/camel-alibaba-mns -am testCommit: Ready for re-review once CI is green. AI-generated comment on behalf of atiaomar1978-hub |
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
github-actions
Bot
added
components
core
catalog
docs
tooling
tooling-maven
core-build-and-dependencies
labels
davsclaus
force-pushed
the
feature/CAMEL-24373-alibaba-phase1
branch
from
August 12, 2026 08:23
9d890ac to
1554797
Compare
davsclaus
requested changes
Aug 12, 2026
davsclaus
left a comment
davsclaus
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the contribution, @atiaomar1978-hub — introducing Alibaba Cloud components is a great addition to the Camel ecosystem. The overall structure follows Camel conventions well (parent module layout, MojoHelper registration, lifecycle management, documentation), and the test coverage is solid.
I found several issues that need to be addressed before this can be merged. The most critical is a version mismatch in the BOM that will break downstream consumers.
Summary of findings
| # | Severity | Finding |
|---|---|---|
| 1 | Blocking | BOM hardcodes 4.22.0-SNAPSHOT instead of 4.23.0-SNAPSHOT |
| 2 | Important | OSS accessKey/secretKey missing secret = true — credentials won't be masked |
| 3 | Important | OSSProducer reads runtime overrides from exchange properties instead of headers |
| 4 | Important | OSSProducer serializes all results to JSON strings via Gson |
| 5 | Moderate | Inconsistent credential annotation style between OSS and MNS |
| 6 | Moderate | operation as @UriPath with label = "producer" but consumer also supported |
| 7 | Minor | Duplicate receipt-handle constants between MNSProperties and MNSHeaders |
See inline comments for details.
This review focuses on project conventions and code correctness. It does not replace specialized review tools such as CodeRabbit, Sourcery, or SonarCloud.
This review was generated by an AI agent (Claude Code on behalf of davsclaus) and may contain inaccuracies. Please verify all suggestions before applying.
Implement Alibaba Cloud OSS component using alibabacloud-oss-v2 SDK: - Producer operations: listBuckets, listObjects, putObject, getObject, deleteObject, copyObject, headObject - Consumer polls listObjectsV2 with optional deleteAfterRead - Shared AlibabaClientBuilderUtil in camel-alibaba-common - Unit tests with AssertJ and Mockito mock OSSClient Co-authored-by: Omar Atie <atiaomar1978-hub@users.noreply.github.com>
Implement Alibaba Cloud Message Service (MNS) component with queue and topic support. Includes sendMessage, receiveMessage, deleteMessage, and publishMessage operations, ScheduledBatchPollingConsumer for queue polling, HealthCheckComponent integration, unit tests with Mockito/AssertJ, and component documentation. Co-authored-by: Omar Atie <atiaomar1978-hub@users.noreply.github.com>
…stry Add BOM/coverage entries, SDK version properties, fix MojoHelper to list component modules only, and add AlibabaClientRegistry with tests. Co-authored-by: Omar Atie <atiaomar1978-hub@users.noreply.github.com>
Co-authored-by: Omar Atie <atiaomar1978-hub@users.noreply.github.com>
- Default MNS queue producer to sendMessage; add test - Validate OSS bucket name for all putObject body types - Advance OSS consumer continuation token only after successful batch - Remove non-existent Spring Boot starter from MNS docs - Regenerate catalog entries for alibaba-oss and alibaba-mns Co-authored-by: Omar Atie <atiaomar1978-hub@users.noreply.github.com>
- Resolve parent/pom.xml merge conflict and keep aws-java-sdk2 2.50.3 - Move OSS client builder from common to OSSUtils in camel-alibaba-oss - Remove unused AlibabaClientRegistry and OSS SDK dependency from common - Cache OSS client on endpoint and close on shutdown when not autowired - Rename OSS content headers to CamelAlibabaOss* convention - Add @OverRide on OSSComponent.createEndpoint() - Document MNS deprecation guidance in component docs Co-authored-by: Cursor Agent <noreply@cursor.com>
Co-authored-by: Cursor Agent <noreply@cursor.com>
…nt lifecycle - Prefer endpoint accessKey/secretKey over empty ServiceKeys bean (OSS) - Cap listObjects results at maxKeys instead of scanning entire bucket - Close MNS client on endpoint stop when not autowired Co-authored-by: Cursor Agent <noreply@cursor.com>
Co-authored-by: Cursor Agent <noreply@cursor.com>
- Rebased on upstream main (4.23.0-SNAPSHOT) - Updated firstVersion and docs to 4.23 - Resolved parent/pom.xml conflicts; alibaba SDK versions in alpha order - Regenerated catalog and component metadata Co-authored-by: Cursor Agent <noreply@cursor.com>
davsclaus
force-pushed
the
feature/CAMEL-24373-alibaba-phase1
branch
from
August 12, 2026 14:02
1554797 to
3adb638
Compare
- Fix BOM alibaba module versions to 4.23.0-SNAPSHOT - Redesign OSS URI: bucketName in path, operation as query param - Mark OSS/MNS credentials with secret=true and security label - OSS producer resolves runtime overrides from headers first - Return structured Map/List bodies instead of Gson JSON strings - Remove duplicate MNS receipt-handle/message constants from MNSProperties - Update tests, docs, and catalog metadata Co-authored-by: Cursor Agent <noreply@cursor.com>
Contributor
Author
Review feedback addressed (@davsclaus)Thanks for the follow-up review. The latest commit (
Docs, tests, component metadata, and catalog JSON updated accordingly. TestsAll alibaba module unit tests passing locally: ./mvnw -pl components/camel-alibaba/camel-alibaba-common,components/camel-alibaba/camel-alibaba-oss,components/camel-alibaba/camel-alibaba-mns -am test -Dtest='org.apache.camel.component.alibaba.**' -Dsurefire.failIfNoSpecifiedTests=falseReady for re-review once CI is green. AI-generated comment on behalf of atiaomar1978-hub |
davsclaus
approved these changes
Aug 12, 2026
…ents Commit generated files produced by the regen build so CI "Fail if there are uncommitted changes" passes. Co-authored-by: Cursor Agent <noreply@cursor.com>
Contributor
Author
|
@davsclaus please re-trigger the CI . thanks |
Contributor
|
triggered |
Contributor
|
🧪 CI tested the following changed modules:
✅ POM dependency changes: targeted tests included Changed properties: alibabacloud-oss-version,aliyun-sdk-mns-version Modules affected by dependency changes (2)
🔬 Scalpel shadow comparison — Scalpel: 587 tested, 22 compile-only — current: 76 all testedMaveniverse Scalpel detected 609 affected modules (current approach: 76).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 (MVP) of CAMEL-24373: introduces the new
components/camel-alibaba/parent module with shared common code and initial Alibaba Cloud components for Object Storage (OSS) and Message Service (MNS).Target version: Camel 4.23.0 (rebased on
main@4.23.0-SNAPSHOT)Modules added
camel-alibaba-commonServiceKeysonly (no SDK dependencies)camel-alibaba-ossalibaba-oss:alibabacloud-oss-v2SDKcamel-alibaba-mnsalibaba-mns:aliyun-sdk-mnsSDKReview feedback addressed
main(4.23.0-SNAPSHOT) per @davsclausOSSUtils.createClient(); removed unused registry from commonOSSEndpoint/MNSEndpointclient caching and shutdown lifecycleCamelAlibabaOss*conventionTest plan
./mvnw -pl components/camel-alibaba/camel-alibaba-common,components/camel-alibaba/camel-alibaba-oss,components/camel-alibaba/camel-alibaba-mns -am testCloses CAMEL-24373 (phase 1 MVP)
AI-generated PR description on behalf of atiaomar1978-hub