feat(components): micrometer supports prometheus format - #25444
Conversation
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 65 tested, 28 compile-only — current: 64 all testedMaveniverse Scalpel detected 93 affected modules (current approach: 64).
|
davsclaus
left a comment
There was a problem hiding this comment.
Nice work moving the Prometheus format support down to camel-micrometer — making it available without the Prometheus registry dependency is a good architectural improvement. The test coverage is thorough.
A few items below — one naming concern and two minor style points.
Note: This review covers project rules, conventions, and code correctness visible from the diff. It does not replace specialized review tools (CodeRabbit, Sourcery) or static analyzers (SonarCloud).
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
5fee9a1 to
98be1f9
Compare
davsclaus
left a comment
There was a problem hiding this comment.
Thanks for moving the Prometheus format support down to camel-micrometer — nice refactor that makes the feature available without requiring the prometheus extension.
I found one code-quality issue that should be fixed before merging, plus a convention item.
This review focuses on project conventions and code correctness. It does not replace specialized review tools (CodeRabbit, Sourcery) or static analyzers (SonarCloud).
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Add a conversion to support the feature from this component instead of the prometheus one Ref CAMEL-24356
98be1f9 to
24f9f8a
Compare
Add a conversion to support the feature from this component instead of the prometheus one
Ref CAMEL-24356
Description
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.AI-assisted contributions
Co-authored-bytrailers) and the PR description identifies the AI tool used.