CAMEL-24528: camel-huggingface - surface Python inference errors in four task predictors - #25854
Merged
Conversation
…our task predictors
TextGenerationPredictor, SummarizationPredictor, QuestionAnsweringPredictor and
TextToImagePredictor set the returned data as the successful result without
checking whether the Python script had returned an error payload. The six other
task predictors guard the output with
`if (result.contains("\"error\"")) throw new RuntimeCamelException(...)`, so a
failed inference in these four was silently delivered as a success. For
text-to-image the JSON error text was served as image/png bytes.
Add the same guard to the four predictors. Text-to-image decodes the returned
bytes to a string to check for the error marker before setting the image body.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 9 tested, 28 compile-only — current: 9 all testedMaveniverse Scalpel detected 37 affected modules (current approach: 9).
|
gnodet
approved these changes
Aug 28, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Clean and consistent fix. The four predictors that were missing error guards (TextGenerationPredictor, SummarizationPredictor, QuestionAnsweringPredictor, TextToImagePredictor) now follow the same error-detection pattern used by the other six predictors.
Key observations:
- The error-detection pattern (
result.contains("\"error\"")) is consistent with the existing codebase across all ten predictors. - Tests cover all four error scenarios plus a happy-path case.
- The component exists on
camel-4.22.xwhere the bug is present — backport is worth considering.
LGTM 👍
AI-generated review on behalf of Guillaume Nodet — verify any suggestions before applying.
Croway
approved these changes
Aug 28, 2026
Contributor
|
I wonder if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
CAMEL-24528
Problem
Ten task predictors delegate to a Python inference script and read the result via
output.getAsString("data").Six of them guard the output before using it:
Four do not:
TextGenerationPredictor,SummarizationPredictor,QuestionAnsweringPredictorand
TextToImagePredictor. When the Python script fails and returns a JSON error payload(
{"error": ...}), these four set it as the successful result:image/png.Fix
Add the same error guard to the four predictors. For text-to-image (whose output is raw image bytes)
the returned bytes are decoded to a string to check for the error marker before the image body is set.
Testing
PredictorErrorHandlingTestasserts each of the four predictors throws on an error payload, andthat a successful text-generation result is still passed through.
mvn -Psourcecheck validategreen.Claude Code on behalf of oscerd