chore: camel-smb - fix SmbConsumerStartingDirectoryMustExistIT for route-start exception wrapping

[davsclaus]

Summary

SmbConsumerStartingDirectoryMustExistIT.testStartingDirectoryMustExist has been failing on main since CAMEL-24404 (#25554) merged. That change made InternalRouteStartupManager.doStartOrResumeRouteConsumers() always wrap consumer startup failures in FailedToStartRouteException.

This test still did:

try {
    context.start();
    Assertions.fail();
} catch (GenericFileOperationFailedException e) {
    ...
}

Since context.start() now throws FailedToStartRouteException (wrapping the original GenericFileOperationFailedException as its cause), the catch clause no longer matched, so the exception propagated uncaught and the test failed with an error on every run — spotted as a CI failure on an unrelated PR (#25892).

#25554 already updated 7 other modules for this same wrapping change (DefaultSupervisingRouteControllerTest, MainSupervisingRouteControllerTest, AiToolEndpointLifecycleTest, etc.) but missed this SMB test since it lives outside that PR's scope.

Fix

Rewritten with AssertJ's assertThatThrownBy, asserting FailedToStartRouteException as the outer type and checking the original message via .cause(), matching the pattern used for the other tests updated by CAMEL-24404. assertj-core was added as a test dependency to camel-smb/pom.xml (version centrally managed in the parent POM) since it wasn't previously present in this module.

I checked the rest of camel-smb's tests for the same try { context.start(); fail(); } catch (...) pattern — this was the only one affected.

Test plan

• mvn -o compile test-compile in components/camel-smb — compiles clean
• mvn -o verify -Dit.test=SmbConsumerStartingDirectoryMustExistIT — passes
• mvn formatter:format impsort:sort — no changes needed

Claude Code on behalf of davsclaus

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run
• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
• You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
• Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[github-actions]

🧪 CI tested the following changed modules:

• components/camel-smb

---

🔬 Scalpel shadow comparison — Scalpel: 9 tested, 27 compile-only — current: 9 all tested

Maveniverse Scalpel detected 36 affected modules (current approach: 9).

⚠️ Modules only in Scalpel (27)

• apache-camel
• camel-allcomponents
• camel-catalog
• camel-catalog-console
• camel-catalog-maven
• camel-catalog-suggest
• camel-componentdsl
• camel-endpointdsl
• camel-endpointdsl-support
• camel-itest
• camel-jbang-core
• camel-jbang-it
• camel-jbang-main
• camel-jbang-plugin-edit
• camel-jbang-plugin-generate
• camel-jbang-plugin-kubernetes
• camel-jbang-plugin-test
• camel-kamelet-main
• camel-launcher
• camel-report-maven-plugin
• camel-route-parser
• camel-yaml-dsl
• camel-yaml-dsl-deserializers
• camel-yaml-dsl-maven-plugin
• coverage
• docs
• dummy-component

Skip-tests mode would test 9 modules (1 direct + 8 downstream), skip tests for 27 (generated code, meta-modules)

Modules Scalpel would test (9)

• camel-jbang-mcp
• camel-jbang-plugin-mcp
• camel-jbang-plugin-route-parser
• camel-jbang-plugin-tui
• camel-jbang-plugin-validate
• camel-launcher-container
• camel-smb
• camel-yaml-dsl-validator
• camel-yaml-dsl-validator-maven-plugin

Modules with tests skipped (27)

• apache-camel
• camel-allcomponents
• camel-catalog
• camel-catalog-console
• camel-catalog-maven
• camel-catalog-suggest
• camel-componentdsl
• camel-endpointdsl
• camel-endpointdsl-support
• camel-itest
• camel-jbang-core
• camel-jbang-it
• camel-jbang-main
• camel-jbang-plugin-edit
• camel-jbang-plugin-generate
• camel-jbang-plugin-kubernetes
• camel-jbang-plugin-test
• camel-kamelet-main
• camel-launcher
• camel-report-maven-plugin
• camel-route-parser
• camel-yaml-dsl
• camel-yaml-dsl-deserializers
• camel-yaml-dsl-maven-plugin
• coverage
• docs
• dummy-component

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

All tested modules (36 modules)

• Camel :: All Components Sync point
• Camel :: Assembly
• Camel :: Catalog :: Camel Catalog
• Camel :: Catalog :: Camel Report Maven Plugin
• Camel :: Catalog :: Camel Route Parser
• Camel :: Catalog :: Console
• Camel :: Catalog :: Dummy Component
• Camel :: Catalog :: Maven
• Camel :: Catalog :: Suggest
• Camel :: Component DSL
• Camel :: Coverage
• Camel :: Docs
• Camel :: Endpoint DSL
• Camel :: Endpoint DSL :: Support
• Camel :: Integration Tests
• Camel :: JBang :: Core
• Camel :: JBang :: Integration tests
• Camel :: JBang :: MCP
• Camel :: JBang :: Main
• Camel :: JBang :: Plugin :: Edit
• Camel :: JBang :: Plugin :: Generate
• Camel :: JBang :: Plugin :: Kubernetes
• Camel :: JBang :: Plugin :: MCP
• Camel :: JBang :: Plugin :: Route Parser
• Camel :: JBang :: Plugin :: TUI
• Camel :: JBang :: Plugin :: Testing
• Camel :: JBang :: Plugin :: Validate
• Camel :: Kamelet Main
• Camel :: Launcher
• Camel :: Launcher :: Container
• Camel :: SMB
• Camel :: YAML DSL
• Camel :: YAML DSL :: Deserializers
• Camel :: YAML DSL :: Maven Plugins
• Camel :: YAML DSL :: Validator
• Camel :: YAML DSL :: Validator Maven Plugin

---

⚙️ View full build and test results

[gnodet]

Clean, correct test fix for a CI failure caused by CAMEL-24404's exception wrapping change (#25554). The assertion pattern matches what PR #25554 used for the seven other modules it updated, and the assertj-core dependency addition is properly scoped.

Observations (non-blocking):

• Verified that no other tests in camel-smb are affected — the other GenericFileOperationFailedException references deal with exchange/producer-level exceptions (extracted from CamelExecutionException.getCause()), not consumer startup failures from context.start().
• The assertion chain checks .cause().hasMessage(...) without also asserting the cause type is GenericFileOperationFailedException. Adding .cause().isInstanceOf(GenericFileOperationFailedException.class) would be marginally more precise, but the message string is specific enough to avoid false positives.

📋 PR Metadata

Aspect	Current	Suggested
Labels	components	→ test (test-only change, no component code modified)
Milestone	(none)	4.23.0

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of Guillaume Nodet