Skip to content

CAMEL-24557: Remove stale langchain4j-tools from AI observability docs - #25910

Merged
davsclaus merged 2 commits into
apache:mainfrom
atiaomar1978-hub:feature/CAMEL-24557-remove-langchain4j-tools-observability-docs-c587
Aug 31, 2026
Merged

CAMEL-24557: Remove stale langchain4j-tools from AI observability docs#25910
davsclaus merged 2 commits into
apache:mainfrom
atiaomar1978-hub:feature/CAMEL-24557-remove-langchain4j-tools-observability-docs-c587

Conversation

@atiaomar1978-hub

@atiaomar1978-hub atiaomar1978-hub commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Updates GenAI observability documentation for Camel 4.23 now that all rollout phases are complete and camel-langchain4j-tools has been removed.

Changes

  • ai-observability.adoc: remove stale langchain4j-tools references; replace phased coverage lists with a single supported-producers section; drop phase numbering from Camel TUI heading
  • catalog ai-observability.adoc (generated): regenerated to match source
  • upgrade guide 4.23: list spring-ai-chat alongside LangChain4j and OpenAI without phase references

Supported producers (current)

langchain4j-chat, langchain4j-agent, langchain4j-embeddings, openai, and spring-ai-chat

JIRA

https://issues.apache.org/jira/browse/CAMEL-24557

AI-generated on behalf of atiaomar1978-hub

@davsclaus
davsclaus marked this pull request as ready for review August 31, 2026 06:34
@davsclaus

Copy link
Copy Markdown
Contributor

remove the phase and make the doc up to date with current, we have done all 3 phases.

@davsclaus
davsclaus marked this pull request as draft August 31, 2026 06:35
@atiaomar1978-hub

Copy link
Copy Markdown
Contributor Author

Addressed @davsclaus's review in 1f001fd:

  • Removed Phase 1 / Phase 3 coverage lists — replaced with a single Supported producers line listing all current components: langchain4j-chat, langchain4j-agent, langchain4j-embeddings, openai, and spring-ai-chat
  • Renamed == Camel TUI integration (Phase 2)== Camel TUI integration
  • Updated camel-4x-upgrade-guide-4_23.adoc to mention Spring AI chat alongside LangChain4j and OpenAI without phase wording
  • Regenerated catalog ai-observability.adoc to match

AI-generated on behalf of atiaomar1978-hub

@davsclaus

Copy link
Copy Markdown
Contributor

there is merge conflicts ^^^

Drop langchain4j-tools from Phase 1 coverage and remove
CamelLangChain4jToolsRequestModel/ResponseModel header entries
now that camel-langchain4j-tools is removed from camel-ai-parent.
Regenerate catalog ai-observability.adoc to match.

Co-authored-by: Cursor <cursoragent@cursor.com>
Replace Phase 1/3 coverage lists with a single supported-producers
section and remove Phase 2 from the Camel TUI heading. Update the 4.23
upgrade guide to list spring-ai-chat alongside LangChain4j and OpenAI
without phase references.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor
cursor Bot force-pushed the feature/CAMEL-24557-remove-langchain4j-tools-observability-docs-c587 branch from 1f001fd to 0705a2d Compare August 31, 2026 06:47
@atiaomar1978-hub

Copy link
Copy Markdown
Contributor Author

@davsclaus Done

@davsclaus
davsclaus marked this pull request as ready for review August 31, 2026 06:50
@github-actions

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions

Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • catalog/camel-catalog
  • components/camel-ai/camel-ai-observability
  • docs

🔬 Scalpel shadow comparison — Scalpel: 18 tested, 25 compile-only — current: 16 all tested

Maveniverse Scalpel detected 43 affected modules (current approach: 16).

⚠️ Modules only in Scalpel (27)
  • apache-camel
  • camel-allcomponents
  • camel-catalog
  • camel-catalog-console
  • camel-catalog-maven
  • camel-catalog-suggest
  • camel-componentdsl
  • camel-endpointdsl
  • camel-endpointdsl-support
  • camel-itest
  • camel-jbang-core
  • camel-jbang-it
  • camel-jbang-main
  • camel-jbang-plugin-edit
  • camel-jbang-plugin-generate
  • camel-jbang-plugin-kubernetes
  • camel-jbang-plugin-test
  • camel-kamelet-main
  • camel-launcher
  • camel-report-maven-plugin
  • camel-route-parser
  • camel-yaml-dsl
  • camel-yaml-dsl-deserializers
  • camel-yaml-dsl-maven-plugin
  • coverage
  • docs
  • dummy-component

Skip-tests mode would test 18 modules (3 direct + 15 downstream), skip tests for 25 (generated code, meta-modules)

Modules Scalpel would test (18)
  • camel-ai-observability
  • camel-catalog
  • camel-jbang-mcp
  • camel-jbang-plugin-mcp
  • camel-jbang-plugin-route-parser
  • camel-jbang-plugin-tui
  • camel-jbang-plugin-validate
  • camel-langchain4j-agent
  • camel-langchain4j-chat
  • camel-langchain4j-embeddings
  • camel-langchain4j-embeddingstore
  • camel-launcher-container
  • camel-mcp-server
  • camel-openai
  • camel-spring-ai-chat
  • camel-yaml-dsl-validator
  • camel-yaml-dsl-validator-maven-plugin
  • docs
Modules with tests skipped (25)
  • apache-camel
  • camel-allcomponents
  • camel-catalog-console
  • camel-catalog-maven
  • camel-catalog-suggest
  • camel-componentdsl
  • camel-endpointdsl
  • camel-endpointdsl-support
  • camel-itest
  • camel-jbang-core
  • camel-jbang-it
  • camel-jbang-main
  • camel-jbang-plugin-edit
  • camel-jbang-plugin-generate
  • camel-jbang-plugin-kubernetes
  • camel-jbang-plugin-test
  • camel-kamelet-main
  • camel-launcher
  • camel-report-maven-plugin
  • camel-route-parser
  • camel-yaml-dsl
  • camel-yaml-dsl-deserializers
  • camel-yaml-dsl-maven-plugin
  • coverage
  • dummy-component

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

All tested modules (43 modules)
  • Camel :: AI :: LangChain4j :: Agent
  • Camel :: AI :: LangChain4j :: Chat
  • Camel :: AI :: LangChain4j :: Embedding
  • Camel :: AI :: LangChain4j :: EmbeddingStore
  • Camel :: AI :: MCP Server
  • Camel :: AI :: Observability
  • Camel :: AI :: OpenAI
  • Camel :: All Components Sync point
  • Camel :: Assembly
  • Camel :: Catalog :: Camel Catalog
  • Camel :: Catalog :: Camel Report Maven Plugin
  • Camel :: Catalog :: Camel Route Parser
  • Camel :: Catalog :: Console
  • Camel :: Catalog :: Dummy Component
  • Camel :: Catalog :: Maven
  • Camel :: Catalog :: Suggest
  • Camel :: Component DSL
  • Camel :: Coverage
  • Camel :: Docs
  • Camel :: Endpoint DSL
  • Camel :: Endpoint DSL :: Support
  • Camel :: Integration Tests
  • Camel :: JBang :: Core
  • Camel :: JBang :: Integration tests
  • Camel :: JBang :: MCP
  • Camel :: JBang :: Main
  • Camel :: JBang :: Plugin :: Edit
  • Camel :: JBang :: Plugin :: Generate
  • Camel :: JBang :: Plugin :: Kubernetes
  • Camel :: JBang :: Plugin :: MCP
  • Camel :: JBang :: Plugin :: Route Parser
  • Camel :: JBang :: Plugin :: TUI
  • Camel :: JBang :: Plugin :: Testing
  • Camel :: JBang :: Plugin :: Validate
  • Camel :: Kamelet Main
  • Camel :: Launcher
  • Camel :: Launcher :: Container
  • Camel :: Spring AI :: Chat
  • Camel :: YAML DSL
  • Camel :: YAML DSL :: Deserializers
  • Camel :: YAML DSL :: Maven Plugins
  • Camel :: YAML DSL :: Validator
  • Camel :: YAML DSL :: Validator Maven Plugin

⚙️ View full build and test results

@davsclaus
davsclaus merged commit 75be05b into apache:main Aug 31, 2026
6 checks passed

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI-generated review on behalf of Guillaume Nodet

LGTM — accurate documentation cleanup.

Verified that:

  1. camel-langchain4j-tools was indeed removed from origin/main (not in camel-ai/pom.xml, source files deleted) — references are correctly cleaned up
  2. The five supported producers listed (langchain4j-chat, langchain4j-agent, langchain4j-embeddings, openai, spring-ai-chat) all exist and have GenAI observability code in their producers — no producer with observability support was omitted
  3. The catalog generated doc is consistent with the source doc
  4. The upgrade guide changes correctly consolidate existing entries and remove phase numbering, while the separate deprecation/migration section for langchain4j-tools was properly left untouched

One nit (not blocking):

  • Long line in upgrade guide (line ~253): The consolidated line listing all three producer families is ~137 chars, slightly exceeding the 120-char soft limit. Consider breaking it for readability, though AsciiDoc renders it fine either way.

Nice cleanup tying up the observability rollout!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants