CAMEL-24557: Remove stale langchain4j-tools from AI observability docs - #25910
Conversation
|
remove the phase and make the doc up to date with current, we have done all 3 phases. |
|
Addressed @davsclaus's review in 1f001fd:
AI-generated on behalf of atiaomar1978-hub |
|
there is merge conflicts ^^^ |
Drop langchain4j-tools from Phase 1 coverage and remove CamelLangChain4jToolsRequestModel/ResponseModel header entries now that camel-langchain4j-tools is removed from camel-ai-parent. Regenerate catalog ai-observability.adoc to match. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace Phase 1/3 coverage lists with a single supported-producers section and remove Phase 2 from the Camel TUI heading. Update the 4.23 upgrade guide to list spring-ai-chat alongside LangChain4j and OpenAI without phase references. Co-authored-by: Cursor <cursoragent@cursor.com>
1f001fd to
0705a2d
Compare
|
@davsclaus Done |
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 18 tested, 25 compile-only — current: 16 all testedMaveniverse Scalpel detected 43 affected modules (current approach: 16).
|
gnodet
left a comment
There was a problem hiding this comment.
🤖 AI-generated review on behalf of Guillaume Nodet
LGTM — accurate documentation cleanup. ✅
Verified that:
camel-langchain4j-toolswas indeed removed fromorigin/main(not incamel-ai/pom.xml, source files deleted) — references are correctly cleaned up- The five supported producers listed (
langchain4j-chat,langchain4j-agent,langchain4j-embeddings,openai,spring-ai-chat) all exist and have GenAI observability code in their producers — no producer with observability support was omitted - The catalog generated doc is consistent with the source doc
- The upgrade guide changes correctly consolidate existing entries and remove phase numbering, while the separate deprecation/migration section for
langchain4j-toolswas properly left untouched
One nit (not blocking):
- Long line in upgrade guide (line ~253): The consolidated line listing all three producer families is ~137 chars, slightly exceeding the 120-char soft limit. Consider breaking it for readability, though AsciiDoc renders it fine either way.
Nice cleanup tying up the observability rollout!
Summary
Updates GenAI observability documentation for Camel 4.23 now that all rollout phases are complete and
camel-langchain4j-toolshas been removed.Changes
langchain4j-toolsreferences; replace phased coverage lists with a single supported-producers section; drop phase numbering from Camel TUI headingai-observability.adoc(generated): regenerated to match sourcespring-ai-chatalongside LangChain4j and OpenAI without phase referencesSupported producers (current)
langchain4j-chat,langchain4j-agent,langchain4j-embeddings,openai, andspring-ai-chatJIRA
https://issues.apache.org/jira/browse/CAMEL-24557
AI-generated on behalf of atiaomar1978-hub