chore(deps): upgrade Apache Avro to 1.12.2 - #26005
Conversation
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet
left a comment
There was a problem hiding this comment.
Clean dependency upgrade from Apache Avro 1.12.1 to 1.12.2 with correct test-JVM configuration for the new trusted-packages validation and a well-written upgrade guide entry documenting the user-visible migration.
Minor observation (non-blocking): The two [source] blocks for the JVM option examples in the upgrade guide lack a language specifier (e.g., [source,text]). Other blocks in the same file use [source,java] or [source,xml]. This is valid AsciiDoc as-is, so not blocking.
General observations:
- The scope of the test-JVM changes is correct — only
camel-avroandcamel-avro-rpcuse Avro's nativeSpecificData/ReflectDataclass-loading paths. The Jackson-based Avro modules are unaffected. - The trusted package sets are minimal and correct.
- The upgrade guide entry is thorough: explains the behavioral change, gives concrete examples, and warns against
*wildcard usage.
📋 PR Metadata
| Aspect | Current | Suggested |
|---|---|---|
| Labels | components, docs, core-build-and-dependencies |
+ dependency |
| Milestone | (none) | 4.23.0 |
| Backport | — | Not needed (author explicitly excludes maintenance branches — appropriate for a user-visible breaking change) |
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of Guillaume Nodet
|
🧪 CI tested the following changed modules:
✅ POM dependency changes: targeted tests included Changed properties: avro-ipc-jetty-version,avro-ipc-netty-version,avro-version Modules affected by dependency changes (8)
🔬 Scalpel shadow comparison — Scalpel: 23 tested, 26 compile-only — current: 10 all testedMaveniverse Scalpel detected 49 affected modules (current approach: 10).
|
Upgrades Apache Avro, Avro compiler, and Avro RPC transports from 1.12.1 to 1.12.2.
Avro 1.12.2 validates classes loaded from schemas and requires explicit trusted packages. Configure the affected Camel test JVMs with the minimum packages needed by their test models, and document the required application migration.
This replaces #26001, which was closed because the version bump is a user-visible compatibility change. It is intentionally not proposed for the camel-4.22.x or camel-4.18.x maintenance branches.