ci: apply threshold to Scalpel-detected modules in incremental build - #26025
Merged
Conversation
Before Scalpel, when the -amd expansion of changed modules exceeded the threshold (50), the build would only test the directly changed modules. With Scalpel, detected dependent modules are added explicitly to -pl, bypassing the threshold entirely. For core module changes (camel-api, camel-support), this means ~591 modules get tested regardless. Strip dependency-detected modules (grep + Scalpel) from the build list when the threshold is exceeded, restoring the pre-Scalpel behavior. The test-dependents label still forces testing all dependents. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
davsclaus
approved these changes
Sep 2, 2026
Contributor
|
@Croway is this related to your JIRA you created |
Contributor
|
Oh yes! I didn't know he already opened this PR, I'll assign the ticket to Guillaume and resolve it. Thanks! |
Croway
approved these changes
Sep 2, 2026
Contributor
Author
Thx, I did not know you created a JIRA ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Claude Code on behalf of gnodet
-amdexpansion of changed modules exceeded the threshold (50), the build would only test the directly changed modules. The CI comment correctly reported "Dependent modules were not tested because the total number of affected modules exceeded the threshold."-pl(merged at step 2c), bypassing the threshold entirely. For core module changes (camel-api,camel-support), this means ~591 modules get tested regardless of the threshold — making the comment misleading.test-dependentslabel still forces testing all dependents.Test plan
.github/path-ignore and won't trigger a full buildcore/camel-support— should only test the directly changed modules, not ~591 dependentstest-dependentslabel still overrides the thresholdCo-Authored-By: Claude Opus 4.6 noreply@anthropic.com