CAMEL-24786 - stabilize Milvus IT test by awaiting proxy marked as started in container log - #26042
Conversation
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 13 tested, 27 compile-only — current: 13 all testedMaveniverse Scalpel detected 40 affected modules (current approach: 13).
|
gnodet
left a comment
There was a problem hiding this comment.
Good approach — waiting for the proxy-ready log message is the right fix for this race condition, and it follows the established pattern used by several other Camel test-infra services (NATS, Infinispan, Consul, etc.).
However, there's a timeout issue that would make this fix counterproductive on the exact platform it targets (ppc64le with slower Milvus 2.6.5).
Also, minor note: the PR title references CAMEL-23794 but the branch name is CAMEL-24786-flakyMilvusIT — one of these JIRA IDs appears incorrect.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of Guillaume Nodet
565c89d to
f2760a3
Compare
started in container log it was causing this sporadic error: ``` Failed to initialize connection. Error: UNKNOWN: service unavailable: internal: Milvus Proxy is not ready yet. please wait ``` this error is occurring very often when using the 2.6.5 image version of Milvus. For ppc64le, this is the version used (there isn't a more recent yet) Co-authored-by: IBM Bob 2.0.3 Signed-off-by: Aurélien Pupier <apupier@ibm.com>
f2760a3 to
7d818e3
Compare
it was causing this sporadic error:
this error is occurring very often when using the 2.6.5 image version of Milvus. For ppc64le, this is the version used (there isn't a more recent yet)
Co-authored-by: IBM Bob 2.0.3
Description
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.AI-assisted contributions
Co-authored-bytrailers) and the PR description identifies the AI tool used.