Skip to content

CAMEL-24601 - fix flakiness in SmbComponentConnectionIT - #26132

Open
apupier wants to merge 1 commit into
apache:mainfrom
apupier:24601-fixFlakySmbComponentConnectionIT.testSendReceive
Open

CAMEL-24601 - fix flakiness in SmbComponentConnectionIT#26132
apupier wants to merge 1 commit into
apache:mainfrom
apupier:24601-fixFlakySmbComponentConnectionIT.testSendReceive

Conversation

@apupier

@apupier apupier commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

one route was potentially messing with the others. I tried to use some specific searchPattern or exclude parameter without success; The easiest is to separate in 2 test classes and Isolate them. Before I got a failure rate around 1 out of 5; now I got 60 in success.

Co-Authored-by: IBM Bob 2.0.3

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

AI-assisted contributions

  • If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., Co-authored-by trailers) and the PR description identifies the AI tool used.

one route was potentially messing with the others. I tried to use some
specific searchPattern or exclude parameter without success; The easiest
is to separate in 2 test classes and Isolate them.
Before I got a failure rate around 1 out of 5; now I got 60 in success.

Co-Authored-by: IBM Bob 2.0.3
Signed-off-by: Aurélien Pupier <apupier@ibm.com>
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • components/camel-smb

🔬 Scalpel shadow comparison — Scalpel: 1 tested, 0 compile-only — current: 9 all tested

Maveniverse Scalpel detected 1 affected modules (current approach: 9).

Modules only in current approach (8)
  • camel-jbang-mcp
  • camel-jbang-plugin-mcp
  • camel-jbang-plugin-route-parser
  • camel-jbang-plugin-tui
  • camel-jbang-plugin-validate
  • camel-launcher-container
  • camel-yaml-dsl-validator
  • camel-yaml-dsl-validator-maven-plugin

Skip-tests mode would test 1 modules (1 direct + 0 downstream), skip tests for 0 (generated code, meta-modules)

Modules Scalpel would test (1)
  • camel-smb

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

All tested modules (9 modules)
  • Camel :: JBang :: MCP
  • Camel :: JBang :: Plugin :: MCP
  • Camel :: JBang :: Plugin :: Route Parser
  • Camel :: JBang :: Plugin :: TUI
  • Camel :: JBang :: Plugin :: Validate
  • Camel :: Launcher :: Container
  • Camel :: SMB
  • Camel :: YAML DSL :: Validator
  • Camel :: YAML DSL :: Validator Maven Plugin

⚙️ View full build and test results

@apupier
apupier marked this pull request as ready for review September 4, 2026 15:08

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean fix for the test flakiness. The root cause was the broad SMB consumer route (fromF("smb:...")) in SmbComponentConnectionIT interfering with the testSendReceive/testDefaultIgnore/testOverride tests — the consumer was picking up files created by those tests before they could read them back. Splitting testSmbRead and its consuming route into a separate @Isolated class eliminates the interference.

@Isolated on both classes is the right call since they share SmbServiceFactory.createSingletonService().

This review was generated by an AI agent, Hermès on behalf of @gnodet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants