CAMEL-24601 - fix flakiness in SmbComponentConnectionIT - #26132
Conversation
one route was potentially messing with the others. I tried to use some specific searchPattern or exclude parameter without success; The easiest is to separate in 2 test classes and Isolate them. Before I got a failure rate around 1 out of 5; now I got 60 in success. Co-Authored-by: IBM Bob 2.0.3 Signed-off-by: Aurélien Pupier <apupier@ibm.com>
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 1 tested, 0 compile-only — current: 9 all testedMaveniverse Scalpel detected 1 affected modules (current approach: 9). Modules only in current approach (8)
Skip-tests mode would test 1 modules (1 direct + 0 downstream), skip tests for 0 (generated code, meta-modules) Modules Scalpel would test (1)
All tested modules (9 modules)
|
gnodet
left a comment
There was a problem hiding this comment.
Clean fix for the test flakiness. The root cause was the broad SMB consumer route (fromF("smb:...")) in SmbComponentConnectionIT interfering with the testSendReceive/testDefaultIgnore/testOverride tests — the consumer was picking up files created by those tests before they could read them back. Splitting testSmbRead and its consuming route into a separate @Isolated class eliminates the interference.
@Isolated on both classes is the right call since they share SmbServiceFactory.createSingletonService().
This review was generated by an AI agent, Hermès on behalf of @gnodet.
one route was potentially messing with the others. I tried to use some specific searchPattern or exclude parameter without success; The easiest is to separate in 2 test classes and Isolate them. Before I got a failure rate around 1 out of 5; now I got 60 in success.
Co-Authored-by: IBM Bob 2.0.3
Description
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.AI-assisted contributions
Co-authored-bytrailers) and the PR description identifies the AI tool used.