CAMEL-13249: invoke applyFilterToCamelHeaders instead of applyFilterToExternalHeaders - #2790
Closed
zregvart wants to merge 1 commit into
Closed
CAMEL-13249: invoke applyFilterToCamelHeaders instead of applyFilterToExternalHeaders#2790zregvart wants to merge 1 commit into
applyFilterToCamelHeaders instead of applyFilterToExternalHeaders#2790zregvart wants to merge 1 commit into
Conversation
... instead of `applyFilterToExternalHeaders` This changes the invocation in `HttpRestHeaderFilterStrategy::applyFilterToCamelHeaders` to delegate to `super::applyFilterToCamelHeaders` instead of `super::applyFilterToExternalHeaders`. Also adds integration test demonstrating the issue and refactors `HttpRestHeaderFilterStrategyTest` from `components/camel-http4` to `/components/camel-http-common` as it doesn't depend on `http4` component and tests a class in `camel-http-common`.
oscerd
approved these changes
Feb 25, 2019
oscerd
left a comment
oscerd
left a comment
Contributor
There was a problem hiding this comment.
LGTM, lets wait for @davsclaus because I'm in doubt if this is wanted or not
davsclaus
approved these changes
Feb 25, 2019
davsclaus
left a comment
davsclaus
left a comment
Contributor
There was a problem hiding this comment.
Yeah this smell like a mistake in the first place. Calling the correct super method is better.
Member
Author
|
Thanks @oscerd & @davsclaus I'll merge this in 2.x and supported 2.23.x and 3.x. |
Croway
pushed a commit
to Croway/camel
that referenced
this pull request
Jun 3, 2025
…rtitions are assigned to preserve the paused state of the Consumer assignment (apache#17831) (apache#2790) Co-authored-by: Pavel Bořík <32341334+pavel-borik@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the invocation in
HttpRestHeaderFilterStrategy::applyFilterToCamelHeadersto delegate tosuper::applyFilterToCamelHeadersinstead ofsuper::applyFilterToExternalHeaders.Also adds integration test demonstrating the issue and refactors
HttpRestHeaderFilterStrategyTestfromcomponents/camel-http4to/components/camel-http-commonas it doesn't depend onhttp4component and tests a class incamel-http-common.@davsclaus @oscerd can you take a look, this seems right to me, but the use of
applyFilterToExternalHeadersvsapplyFilterToCamelHeadersseems intentional so I could be missing something.If this change gets approved I'll backport it to
2.23.xand forward port it tomaster.