CAMEL-12665 - Apache Pulsar integration via component - #2866
Closed
foamdino wants to merge 4 commits into
Closed
Conversation
pull from upstream
addressing apache review comments rename from Utils -> Impl change to interface remove THG specific string remove THG specific string add testcontainers support and fix PulsarConcurrentConsumerInTest fix more container tests add component META-INF fix documentation, remove unneeded method call renaming tests remove jdk properties remove empty retry code fix tests remove commented out logging
oscerd
approved these changes
Apr 9, 2019
Contributor
|
I merged this on master, but I had to change some stuff. For example the PulsarComponent constructor and a bunch of other stuff, we need to align the logic into 2.x too. |
Contributor
|
Can you please update the documentation too? What is there actually, it's autogenerated, but you can add example and explanations. We can add the same to 2.x, once you aligned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the other Pull Request however based on master rather than 2.x