CAMEL-16594 Support more than one active shard in DynamoDB stream.#6151
Closed
PyvesB wants to merge 2 commits into
Closed
CAMEL-16594 Support more than one active shard in DynamoDB stream.#6151PyvesB wants to merge 2 commits into
PyvesB wants to merge 2 commits into
Conversation
oscerd
approved these changes
Sep 23, 2021
Contributor
oscerd
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks a lot for the work. @davsclaus can you have a look too? Thanks
davsclaus
approved these changes
Sep 23, 2021
Contributor
|
Can you add a note to the 3.12 upgrade guide about the option renamed |
d5f23de to
a6a74f8
Compare
oscerd
approved these changes
Sep 23, 2021
Contributor
|
I'm going to merge this today. I think it would be really nice to have a blog post about how to use this and maybe a bit more love to this component. |
Contributor
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[CAMEL-XXX] Fixes bug in camel-file component, where you replaceCAMEL-XXXwith the appropriate JIRA issue.mvn clean install -Psourcecheckin your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
This pull request achieves the following:
iteratorTypeandsequenceNumberProviderparameters. My reasoning as to why these don't make much sense can be found in CAMEL-16594.streamIteratorTypeparameter which can have two values,FROM_LATESTandFROM_START.