CAMEL-18792: camel-hdfs - Make integration tests runnable without a real cluster#8828
Merged
orpiske merged 3 commits intoapache:mainfrom Dec 6, 2022
Merged
CAMEL-18792: camel-hdfs - Make integration tests runnable without a real cluster#8828orpiske merged 3 commits intoapache:mainfrom
orpiske merged 3 commits intoapache:mainfrom
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 If necessary Apache Camel Committers may access logs and test results in the job summaries! |
oscerd
approved these changes
Dec 3, 2022
Contributor
|
Thanks for helping with this. I wonder if the test used a hardcoded port number (9000 ?) then can we try using AvailablePortFinder which can find a free port number, as CI server may have "port number in use" problem. |
Contributor
Author
|
Thanks for the comment! I'll fix the PR to leverage AvailablePortFinder. |
orpiske
approved these changes
Dec 4, 2022
Contributor
Thanks for your contribution! +1 for adding it to the |
* Replace the current Docker-based test-infra for HDFS with another implementation which leverages MiniDFSCluster, since the former seems to be unable to run all integration tests once with a single `mvn verify` command for some reason. * Use AvailablePortFinder to determine Namenode's port for avoiding port conflict on the CI environment.
Contributor
Author
|
Thanks! Just updated the PR. With this PR, I ensured all unit and integration tests succeeded, as follows: |
Contributor
Components tested:
|
davsclaus
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[CAMEL-XXX] Fixes bug in camel-file component, where you replaceCAMEL-XXXwith the appropriate JIRA issue.mvn clean install -Psourcecheckin your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md