Skip to content

feat: support matching functions to filter policies#222

Merged
hsluoyz merged 1 commit into
apache:masterfrom
timabilov:feat/filtered-policy-match-fn-support
Nov 27, 2021
Merged

feat: support matching functions to filter policies#222
hsluoyz merged 1 commit into
apache:masterfrom
timabilov:feat/filtered-policy-match-fn-support

Conversation

@timabilov
Copy link
Copy Markdown
Contributor

@timabilov timabilov commented Nov 22, 2021

Support patterns in policy to mimic mathers keymatch and custom functions

Fix: #223

@casbin-bot
Copy link
Copy Markdown

@ffyuanda @Zxilly @techoner @elfisworking please review

@timabilov timabilov force-pushed the feat/filtered-policy-match-fn-support branch from f468169 to cacb736 Compare November 22, 2021 21:31
@hsluoyz
Copy link
Copy Markdown
Member

hsluoyz commented Nov 23, 2021

Comment thread tests/test_management_api.py
Comment thread tests/test_management_api.py
@hsluoyz hsluoyz requested a review from abichinger November 23, 2021 11:08
@hsluoyz
Copy link
Copy Markdown
Member

hsluoyz commented Nov 23, 2021

@abichinger plz review

@abichinger
Copy link
Copy Markdown
Contributor

@hsluoyz I will review after the requested changes of Abingcbc have been implemented.

@timabilov timabilov force-pushed the feat/filtered-policy-match-fn-support branch from cacb736 to 8b99039 Compare November 26, 2021 11:11
@timabilov timabilov requested a review from Abingcbc November 26, 2021 11:13
@timabilov timabilov force-pushed the feat/filtered-policy-match-fn-support branch 2 times, most recently from 244f4c0 to 04be6cb Compare November 26, 2021 12:02
Copy link
Copy Markdown
Contributor

@abichinger abichinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution!

Comment thread tests/test_management_api.py Outdated
Comment thread tests/test_management_api.py Outdated
@timabilov timabilov force-pushed the feat/filtered-policy-match-fn-support branch from 04be6cb to 67d05a7 Compare November 27, 2021 14:57
Signed-off-by: timabilov <timabilov33@gmail.com>
@timabilov timabilov force-pushed the feat/filtered-policy-match-fn-support branch from 67d05a7 to 5dc848d Compare November 27, 2021 15:01
@timabilov timabilov requested a review from abichinger November 27, 2021 15:04
@hsluoyz hsluoyz merged commit 9d0528d into apache:master Nov 27, 2021
github-actions Bot pushed a commit that referenced this pull request Nov 27, 2021
# [1.12.0](v1.11.1...v1.12.0) (2021-11-27)

### Features

* support matching functions to filter policies ([#222](#222)) ([9d0528d](9d0528d))
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Chimou0 pushed a commit to Chimou0/pycasbin that referenced this pull request Jul 17, 2025
Signed-off-by: timabilov <timabilov33@gmail.com>
Chimou0 pushed a commit to Chimou0/pycasbin that referenced this pull request Jul 17, 2025
# [1.12.0](apache/casbin-pycasbin@v1.11.1...v1.12.0) (2021-11-27)

### Features

* support matching functions to filter policies ([apache#222](apache#222)) ([9d0528d](apache@9d0528d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: get filtered policy matching function support for consistency

5 participants