[Bug] When there is a comma in the policy, the policy fails to load.

[leeqvip]

Want to prioritize this issue? Try:

---

Describe the bug
When there is a comma in the policy, the policy fails to load.

To Reproduce

m, _ := model.NewModelFromFile("examples/rbac_model.conf")
persist.LoadPolicyLine(`p, alice, data, r.act in ("get", "post")`, m)
m.PrintPolicy() // Nothing is printed , it should output `[p alice data r.act in ("get", "post")]`

Additional context
Probably there was a problem in CSV Reader ：https://github.com/casbin/casbin/blob/master/persist/adapter.go#L30
Can we provide a method like this :

func LoadPolicy(tokens []string, m model.Model) {
	key := tokens[0]
	sec := key[:1]
	m[sec][key].Policy = append(m[sec][key].Policy, tokens[1:])
	m[sec][key].PolicyMap[strings.Join(tokens[1:], model.DefaultSep)] = len(m[sec][key].Policy) - 1
}

[casbin-bot]

@closetool @tangyang9464

[hsluoyz]

@tangyang9464

[tangyang9464]

@techoner you should use like this

persist.LoadPolicyLine(`p, alice, data, "r.act in (""get"", ""post"")"`, m)
l := &log.DefaultLogger{}
l.EnableLog(true)
m.SetLogger(l)
m.PrintPolicy()

If double-quotes are used to enclose fields, then a double-quote appearing inside a field must be escaped by preceding it with another double quote.
And you must set a logger.

[leeqvip]

@tangyang9464 I think we have the same problem with orm-adapter, such as gorm-adapter adapter.go#L398, adding double-quotes is unnecessary, we can load the policy from the array.

We can implement two functions:

1. LoadPolicyLine or FileAdapter supports the specified separator
2. Support load policies from array

[tangyang9464]

@techoner Suppose we have a policy.csv, how to get the array? We can solve this problem as above, I think support the specified separator is not necessary

[leeqvip]

@tangyang9464 We can split csv into an array using delimiters. In more cases, we use DatabaseAdapter. However, we need to add double quotes to each column, then concatenate it into a string, and then split it. This is redundant.

[leeqvip]

Use part of gorm-adapter(gorm-adapter adapter.go#L398) code to make an example :

type CasbinRule struct {
	ID    uint   `gorm:"primaryKey;autoIncrement"`
	Ptype string `gorm:"size:100"`
	V0    string `gorm:"size:100"`
	V1    string `gorm:"size:100"`
	V2    string `gorm:"size:100"`
	V3    string `gorm:"size:100"`
	V4    string `gorm:"size:100"`
	V5    string `gorm:"size:100"`
}

func (CasbinRule) TableName() string {
	return "casbin_rule"
}

func ruleToLineText(line CasbinRule) string{
	var p = []string{line.Ptype,
		strconv.Quote(line.V0), strconv.Quote(line.V1), strconv.Quote(line.V2),
		strconv.Quote(line.V3), strconv.Quote(line.V4), strconv.Quote(line.V5)}

	var lineText string
	if line.V5 != "" {
		lineText = strings.Join(p, ", ")
	} else if line.V4 != "" {
		lineText = strings.Join(p[:6], ", ")
	} else if line.V3 != "" {
		lineText = strings.Join(p[:5], ", ")
	} else if line.V2 != "" {
		lineText = strings.Join(p[:4], ", ")
	} else if line.V1 != "" {
		lineText = strings.Join(p[:3], ", ")
	} else if line.V0 != "" {
		lineText = strings.Join(p[:2], ", ")
	}

	return lineText
}

func Test(t *testing.T) {
	m, _ := model.NewModelFromFile("examples/rbac_model.conf")
	rule := CasbinRule{
		Ptype: "p",
		V0:    "alice",
		V1:    "data",
		V2:    `r.act in ("get", "post")`,
	}

	line := ruleToLineText(rule)
	fmt.Println(line) //p, "alice", "data", "r.act in (\"get\", \"post\")"
	persist.LoadPolicyLine(line, m)
	t.Log(m["p"]["p"].Policy) // [] Does not meet expectations

	rule.V2 = `r.act in (""get"", ""post"")`
	line = ruleToLineText(rule)
	fmt.Println(line) // p, "alice", "data", "r.act in (\"\"get\"\", \"\"post\"\")"
	persist.LoadPolicyLine(line, m)
	t.Log(m["p"]["p"].Policy) // [] Does not meet expectations 
}

[tangyang9464]

@techoner I got it and I think the csv file (FileAdapter) still needs double quotes to split. But the database adapter doesn't need delimiter. Maybe we can implement a method LoadPolicyLineByArray specifically for the database adapter.
In csv file, you still need to use like "r.act in (""get"", ""post"")" but in db you can just use normally like r.act in ("get", "post")

[leeqvip]

@hsluoyz @tangyang9464 Did I not understand enough?

In my database like this :

ptype	v0	v1	v2
p	alice	data	r.act in ("get", "post")
p	bob	data	1 == 1

Code like this:

	m, _ := model.NewModelFromString(`
[request_definition]
r = sub, obj, act

[policy_definition]
p = sub, obj, act

[role_definition]
g = _, _

[policy_effect]
e = some(where (p.eft == allow))

[matchers]
m = g(r.sub, p.sub) && r.obj == p.obj && eval(r.act)
`)
	a, _ := gormadapter.NewAdapter("mysql", "root:yourpassword@tcp(127.0.0.1:3306)/", "test") // Your driver and data source.
	e, _ := casbin.NewEnforcer(m, a, true)

	t.Log(e.GetModel()["p"]["p"].Policy)  // It only outputs:  [[bob data 1 == 1]]

Why the first policy is not loaded ?

[tangyang9464]

@hsluoyz @tangyang9464 Did I not understand enough?

In my database like this :

ptype	v0	v1	v2
p	alice	data	r.act in ("get", "post")
p	bob	data	1 == 1

Code like this:

	m, _ := model.NewModelFromString(`
[request_definition]
r = sub, obj, act

[policy_definition]
p = sub, obj, act

[role_definition]
g = _, _

[policy_effect]
e = some(where (p.eft == allow))

[matchers]
m = g(r.sub, p.sub) && r.obj == p.obj && eval(r.act)
`)
	a, _ := gormadapter.NewAdapter("mysql", "root:yourpassword@tcp(127.0.0.1:3306)/", "test") // Your driver and data source.
	e, _ := casbin.NewEnforcer(m, a, true)

	t.Log(e.GetModel()["p"]["p"].Policy)  // It only outputs:  [[bob data 1 == 1]]

Why the first policy is not loaded ?

As mentioned above, I will make some changes to the adapter. Then it can be used normally after that