CASSANDRA-19727: Bulk writer fails validation stage when writing to a…#61
Conversation
… cluster using RandomPartitioner Patch by Francisco Guerrero; Reviewed by Yifan Cai for CASSANDRA-19727
| import org.apache.cassandra.distributed.api.TokenSupplier; | ||
| import org.apache.cassandra.distributed.shared.ClusterUtils; | ||
| import org.apache.cassandra.distributed.shared.Versions; | ||
| import org.apache.cassandra.sidecar.adapters.base.Partitioner; |
There was a problem hiding this comment.
why does it depends on sidecar's partitioner? Can it implement with org.apache.cassandra.spark.data.partitioner.Partitioner instead?
It is unrelated with this patch. So I am fine w/o addressing this.
There was a problem hiding this comment.
ah yes, we don't have access to org.apache.cassandra.spark.data.partitioner.Partitioner here. I will not address it here, but it's something we need to address at some point
| import static org.apache.cassandra.testing.TestUtils.TEST_KEYSPACE; | ||
|
|
||
| class SparkBulkWriterSimpleTest extends SharedClusterSparkIntegrationTestBase | ||
| class SparkBulkAnalyticsSimpleTest extends SharedClusterSparkIntegrationTestBase |
There was a problem hiding this comment.
Since you are renaming the class.. would it be more fit to name it CassandraAnalyticsSimpleTest?
"SparkBulkAnalytics" means "CassandraAnalytics" here.
There was a problem hiding this comment.
That was my first choice, so let me change it to CassandraAnalyticsSimpleTest
2 participants
… cluster using RandomPartitioner
Patch by Francisco Guerrero; Reviewed by Yifan Cai for CASSANDRA-19727