Skip to content

JAVA-1871: Change LOCAL_SERIAL.isDCLocal() to return true #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tolbertam merged 1 commit into from
Aug 7, 2018
Merged

JAVA-1871: Change LOCAL_SERIAL.isDCLocal() to return true #1070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- [bug] JAVA-1924: StatementWrapper setters should return the wrapping statement.
- [new feature] JAVA-1532: Add Codec support for Java 8's LocalDateTime and ZoneId.
- [improvement] JAVA-1786: Use Google code formatter.
- [bug] JAVA-1871: Change LOCAL\_SERIAL.isDCLocal() to return true.

Merged from 3.5.x:

Expand Down
5 changes: 3 additions & 2 deletions driver-core/src/main/java/com/datastax/driver/core/ConsistencyLevel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,11 @@ static ConsistencyLevel fromCode(int code) {
/**
* Whether or not this consistency level applies to the local data-center only.
*
* @return whether this consistency level is {@code LOCAL_ONE} or {@code LOCAL_QUORUM}.
* @return whether this consistency level is {@code LOCAL_ONE}, {@code LOCAL_QUORUM}, or {@code
* LOCAL_SERIAL}.
*/
public boolean isDCLocal() {
return this == LOCAL_ONE || this == LOCAL_QUORUM;
return this == LOCAL_ONE || this == LOCAL_QUORUM || this == LOCAL_SERIAL;
}

/**
Expand Down
7 changes: 7 additions & 0 deletions upgrade_guide/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
The purpose of this guide is to detail changes made by successive
versions of the Java driver.

### 3.6.0

1. `ConsistencyLevel.LOCAL_SERIAL.isDCLocal()` now returns true. In driver
code, `isDCLocal()` is only used when evaluating a Statement's
ConsistencyLevel (which does not include Serial CLs), but as a matter of
correctness this was updated.

### 3.5.0

1. The `DowngradingConsistencyRetryPolicy` is now deprecated, see [JAVA-1752].
Expand Down