NODEJS-674: NODEJS-677: NODEJS-678: NODEJS-679: CI for C* 4.1, 5.0, DSE-6.9, and HCD#426
Merged
absurdfarce merged 67 commits intoapache:masterfrom Oct 23, 2024
Merged
NODEJS-674: NODEJS-677: NODEJS-678: NODEJS-679: CI for C* 4.1, 5.0, DSE-6.9, and HCD#426absurdfarce merged 67 commits intoapache:masterfrom
absurdfarce merged 67 commits intoapache:masterfrom
Conversation
SiyaoIsHiding
changed the title
absurdfarce
reviewed
Sep 30, 2024
Contributor
absurdfarce
left a comment
absurdfarce
left a comment
There was a problem hiding this comment.
This looks broadly correct to me. Let's take another pass once C* 5.0.1 is officially released; assuming all the tests are still green once we've changed our dependency to that release I'm good with what we have here.
Closed
SiyaoIsHiding
changed the title
absurdfarce
approved these changes
Oct 23, 2024
Contributor
absurdfarce
left a comment
absurdfarce
left a comment
There was a problem hiding this comment.
Nice work @SiyaoIsHiding!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tinkerpop problem for DSE-6.9 is pending to be fixed.