-
Notifications
You must be signed in to change notification settings - Fork 205
NODEJS-674: NODEJS-677: NODEJS-678: NODEJS-679: CI for C* 4.1, 5.0, DSE-6.9, and HCD #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8bcd338
86da0c0
34d5024
0699654
5a5a9d8
e715972
406a8b6
7653d95
e33ba76
ddcdec4
3796202
3fe64ce
c59e57c
dc66e2e
28fe313
594be60
2a4575d
3f5143d
ed616b5
d4bcb14
552589e
73672c9
5e91c29
51a00a9
72e6fa8
ffd0ded
a324b5e
824eca6
3873621
db633d4
70a95e3
ffcc240
d67111a
441a3a8
2618f42
d062967
44ca6af
653a30f
845b0fa
fcd0144
7cabb9a
6b42d4c
90a3722
7bfdb9d
54ae08b
4155270
54633fe
cd583f4
d9ea8f5
23b267b
37255d9
7f02b84
1017261
6aaf093
bd49d08
4a8f849
80112a3
2c5b5e0
7b6f29d
2f2a0ea
2a503dd
70cfb40
ab9eb82
60ea99b
4c908ba
a736b3a
9c35671
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -130,7 +130,12 @@ vdescribe('dse-5.0', 'Polygon @SERVER_API', function () { | |
| normalizedCoordinates.push([c[0], c[2], c[1], c[3]]); | ||
| } | ||
| } | ||
| assert.deepEqual(normalizedCoordinates, polygon.toJSON().coordinates); | ||
| if (helper.isDseGreaterThan('6.9')) { | ||
| //TODO: find documentation | ||
| assert.deepEqual(value, polygon.toJSON()); | ||
| }else{ | ||
| assert.deepEqual(normalizedCoordinates, polygon.toJSON().coordinates); | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Change to address NODEJS-675. Worth noting that there is some commentary in that test about why this normalization is occurring. Might be worth mentioning to the DSE team that we noticed this change and check with them about whether this was a deliberate modification on their part or an unintended side effect.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Worth noting: @SiyaoIsHiding has asked this question internally but we haven't heard a response back.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Created JIRA ticket: https://datastax.jira.com/browse/DSP-24515 |
||
| eachNext(); | ||
| }); | ||
| }); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.