Expose settings in virtual table for CASSANDRA-14573 - #242
Closed
clohfink wants to merge 5 commits into
Closed
Conversation
clohfink
force-pushed
the
trunk-14573
branch
2 times, most recently
from
August 14, 2018 15:56
ade798f to
a4463e7
Compare
iamaleksey
requested changes
Aug 14, 2018
Member
There was a problem hiding this comment.
Not that I mind the change, but it isn't necessary for this patch, and there is metadata() if it were.
Member
There was a problem hiding this comment.
A lot of unused imports here.
Member
There was a problem hiding this comment.
Doesn't really need to be static. Can also be a map of name -> Field, so that data(DecoratedKey partitionKey) is cleaner.
Member
There was a problem hiding this comment.
Doesn't handle array values like the other data() implementation.
Member
There was a problem hiding this comment.
Should probably factor out this whole block into a method usable by both data() implementations. String fieldValue(Field field, Config config)?
iamaleksey
reviewed
Aug 14, 2018
Member
There was a problem hiding this comment.
Wrong import order. See https://wiki.apache.org/cassandra/CodeStyle
Member
There was a problem hiding this comment.
Is this the toString() implementation we want? Like the other three, it's missing fields, intentionally or not (if intentionally, maybe comment why so?). Also, this string helper prefixes the map with the class name, and it doesn't look pretty in CQL output, subjectively.
iamaleksey
reviewed
Aug 14, 2018
Member
There was a problem hiding this comment.
It's not invalid to query a table for a non-existent partition key, you just return an empty data set in CQL.
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Sep 10, 2021
…oken metadata) (apache#242) Introduced TokenMetadataProvider to abstract access to TokenMetadata and make it pluggable.
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Mar 21, 2022
…oken metadata) (apache#242) Introduced TokenMetadataProvider to abstract access to TokenMetadata and make it pluggable. (cherry picked from commit 8c0a970)
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Jun 13, 2022
…oken metadata) (apache#242) Introduced TokenMetadataProvider to abstract access to TokenMetadata and make it pluggable. (cherry picked from commit 8c0a970) (cherry picked from commit 58b15c2)
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Nov 24, 2022
…oken metadata) (apache#242) Introduced TokenMetadataProvider to abstract access to TokenMetadata and make it pluggable. (cherry picked from commit 8c0a970) (cherry picked from commit 58b15c2) (cherry picked from commit 1b2034e)
adelapena
pushed a commit
to adelapena/cassandra
that referenced
this pull request
Sep 26, 2023
…oken metadata) (apache#242) Introduced TokenMetadataProvider to abstract access to TokenMetadata and make it pluggable. (cherry picked from commit 8c0a970) (cherry picked from commit 58b15c2) (cherry picked from commit 1b2034e) (cherry picked from commit b24d83f) (cherry picked from commit 19e5337)
ekaterinadimitrova2
pushed a commit
to ekaterinadimitrova2/cassandra
that referenced
this pull request
Jun 3, 2024
…oken metadata) (apache#242) Introduced TokenMetadataProvider to abstract access to TokenMetadata and make it pluggable. (cherry picked from commit 8c0a970) (cherry picked from commit 58b15c2) (cherry picked from commit 1b2034e) (cherry picked from commit b24d83f) (cherry picked from commit 19e5337) (cherry picked from commit a790c81) STAR-789 Fix order of CUSTOM_TMD_PROVIDER_PROPERTY in CassandraRelevantProperties
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
…oken metadata) (apache#242) Introduced TokenMetadataProvider to abstract access to TokenMetadata and make it pluggable. (cherry picked from commit 8c0a970) (cherry picked from commit 58b15c2) (cherry picked from commit 1b2034e) (cherry picked from commit b24d83f) (cherry picked from commit 19e5337) (cherry picked from commit a790c81) STAR-789 Fix order of CUSTOM_TMD_PROVIDER_PROPERTY in CassandraRelevantProperties
lesnik2u
pushed a commit
to lesnik2u/cassandra
that referenced
this pull request
May 26, 2026
…oken metadata) (apache#242) Introduced TokenMetadataProvider to abstract access to TokenMetadata and make it pluggable. (cherry picked from commit 8c0a970) (cherry picked from commit 58b15c2) (cherry picked from commit 1b2034e) (cherry picked from commit b24d83f) (cherry picked from commit 19e5337) (cherry picked from commit a790c81) STAR-789 Fix order of CUSTOM_TMD_PROVIDER_PROPERTY in CassandraRelevantProperties (Rebase of commit c698031)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.