Skip to content

[CASSANDRA-15450] in-jvm dtest cluster uncaughtExceptions propagation of exception goes to the wrong instance, it uses cluster generation when it should be using the instance id#397

Closed
dcapwell wants to merge 1 commit intoapache:trunkfrom
dcapwell:dtestUncaughtExceptionWrongNode
Closed

Conversation

@dcapwell
Copy link
Contributor

@dcapwell dcapwell commented Dec 12, 2019

No description provided.

@dcapwell
[CASSANDRA-15450] in-jvm dtest cluster uncaughtExceptions propagation…
f1c2c0a 
… of exception goes to the wrong instance, it uses cluster generation when it should be using the instance id
@JeetKunDoug
Copy link
Contributor

JeetKunDoug commented Dec 13, 2019

👍 - only question is if we really need to change the getGeneration method name... it ends up it's no longer used internally, and I doubt there are many (any) external users of it, but it's changing a public API which is always a bit of a concern to me.

@dcapwell
Copy link
Contributor Author

dcapwell commented Dec 13, 2019

Yeah, I get that. This is something I talked with Alex a little about so thought good time to rename.

Since it's dead code also glad to delete

@dcapwell dcapwell closed this Jan 28, 2020
@dcapwell dcapwell deleted the dtestUncaughtExceptionWrongNode branch January 28, 2020 00:48
blambov pushed a commit to blambov/cassandra that referenced this pull request Jun 13, 2022
@mike-tr-adamson @jacek-lewandowski
STAR-1226 Allow mutation of where clause relations (apache#397)
83881ad 
(cherry picked from commit a303a08)
blambov pushed a commit to blambov/cassandra that referenced this pull request Nov 24, 2022
@mike-tr-adamson @jacek-lewandowski
STAR-1226 Allow mutation of where clause relations (apache#397)
3da8b62 
(cherry picked from commit a303a08)
(cherry picked from commit 83881ad)
adelapena pushed a commit to adelapena/cassandra that referenced this pull request Sep 26, 2023
@mike-tr-adamson @djatnieks
STAR-1226 Allow mutation of where clause relations (apache#397)
52f26ee 
(cherry picked from commit a303a08)
(cherry picked from commit 83881ad)
(cherry picked from commit 3da8b62)
(cherry picked from commit a34ff14)
ekaterinadimitrova2 pushed a commit to ekaterinadimitrova2/cassandra that referenced this pull request Jun 3, 2024
@mike-tr-adamson @djatnieks
STAR-1226 Allow mutation of where clause relations (apache#397)
10063a7 
(cherry picked from commit a303a08)
(cherry picked from commit 83881ad)
(cherry picked from commit 3da8b62)
(cherry picked from commit a34ff14)
(cherry picked from commit 52f26ee)
michaelsembwever pushed a commit to thelastpickle/cassandra that referenced this pull request Jan 7, 2026
@mike-tr-adamson @djatnieks
STAR-1226 Allow mutation of where clause relations (apache#397)
e29ef64 
(cherry picked from commit a303a08)
(cherry picked from commit 83881ad)
(cherry picked from commit 3da8b62)
(cherry picked from commit a34ff14)
(cherry picked from commit 52f26ee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcapwell @JeetKunDoug

Comments