CASSANDRA-20736 Add CMS membership as a field in ClusterMetadata#4915
Closed
beobal wants to merge 30 commits into
Closed
CASSANDRA-20736 Add CMS membership as a field in ClusterMetadata#4915beobal wants to merge 30 commits into
beobal wants to merge 30 commits into
Conversation
…e local node state to gossip
… to setup Directory
krummas
requested changes
Jul 3, 2026
krummas
left a comment
krummas
left a comment
Member
There was a problem hiding this comment.
-
HintDispatcher.java, line 279 should use
placement(..)notplacements.getI think -
make
ClusterMetadata.placementseither private or remove theplacements()method to only have one way of accessing these -
PlacementsChangeListener no longer invalidates local ranges when meta placements change
| Replica replica = new Replica(endpoint, entireRange, true); | ||
| ReplicationParams metaParams = ReplicationParams.meta(prev); | ||
| if (!prev.fullCMSMembers().contains(endpoint)) | ||
| if (!prev.fullCMSMemberIds().contains(removal)) |
| { | ||
| MovementMap.Builder movementMapBuilder = MovementMap.builder(); | ||
| DataPlacements placements = metadata.placements; | ||
| DataPlacements placements = metadata.placements(); |
Member
There was a problem hiding this comment.
I think this changes behaviour now when meta placements are not here? I guess it makes sense to be able to rebuild meta ks?
beobal
force-pushed
the
samt/CASSANDRA-20736
branch
from
5dc1288 to
9cb5d0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira