Render SubnetGroups as JSON in system_views.settings - #5029
Closed
frankgh wants to merge 1 commit into
Closed
Conversation
smiklosovic
self-requested a review
August 17, 2026 08:56
smiklosovic
approved these changes
Aug 17, 2026
Contributor
|
would be nice to add a test for each value of a key that it is a valid json |
frankgh
force-pushed
the
CASSANDRA-21579
branch
from
August 21, 2026 20:43
6b55e5c to
1ccaa20
Compare
SubnetGroups.Group has no getters, so a Set<Group> (e.g. the *_error_reporting_exclusions settings) fails Jackson bean introspection and SettingsTable silently falls back to the legacy toString() format while every other collection renders JSON. This fork ships those settings populated by default, so the table always showed a mix of JSON and non-JSON values. Add @jsonvalue to Group so it serializes as its CIDR string. patch by Francisco Guerrero; reviewed by Stefan Miklosovic for CASSANDRA-21579
frankgh
force-pushed
the
CASSANDRA-21579
branch
from
August 26, 2026 17:20
1ccaa20 to
4a621fc
Compare
Contributor
Author
|
Closed via 29b0bec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SubnetGroups.Group has no getters, so a Set (e.g. the *_error_reporting_exclusions settings) fails Jackson bean introspection and SettingsTable silently falls back to the legacy toString() format while every other collection renders JSON. This fork ships those settings populated by default, so the table always showed a mix of JSON and non-JSON values. Add @jsonvalue to Group so it serializes as its CIDR string.
patch by Francisco Guerrero; reviewed by TBD for CASSANDRA-21579