CASSANDRA-16532 (3.0): Fix flaky ScrubTest - #947
Closed
adelapena wants to merge 2 commits into
Closed
Conversation
adelapena
pushed a commit
to adelapena/cassandra
that referenced
this pull request
Jan 30, 2024
If there is an exception in the `VectorTopKProcessor#filter` method, we do not close the source `partitions` object, which could result in a leak. I saw this in testing on apache#929 when I hit an NPE, and this fix prevent a resource leak. However, I don't see a good way to hit this exception with a normal test. We could hit this for queries that timeout in the index search.
ekaterinadimitrova2
pushed a commit
to ekaterinadimitrova2/cassandra
that referenced
this pull request
Jun 3, 2024
If there is an exception in the `VectorTopKProcessor#filter` method, we do not close the source `partitions` object, which could result in a leak. I saw this in testing on apache#929 when I hit an NPE, and this fix prevent a resource leak. However, I don't see a good way to hit this exception with a normal test. We could hit this for queries that timeout in the index search.
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
If there is an exception in the `VectorTopKProcessor#filter` method, we do not close the source `partitions` object, which could result in a leak. I saw this in testing on apache#929 when I hit an NPE, and this fix prevent a resource leak. However, I don't see a good way to hit this exception with a normal test. We could hit this for queries that timeout in the index search.
lesnik2u
pushed a commit
to lesnik2u/cassandra
that referenced
this pull request
May 26, 2026
If there is an exception in the `VectorTopKProcessor#filter` method, we do not close the source `partitions` object, which could result in a leak. I saw this in testing on apache#929 when I hit an NPE, and this fix prevent a resource leak. However, I don't see a good way to hit this exception with a normal test. We could hit this for queries that timeout in the index search. (Rebase of commit 6476a6e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.