[CELEBORN-1190][FOLLOWUP] Apply error prone patch and suppress some problems#2180
[CELEBORN-1190][FOLLOWUP] Apply error prone patch and suppress some problems#2180cxzl25 wants to merge 3 commits intoapache:mainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2180 +/- ##
==========================================
+ Coverage 47.13% 47.14% +0.01%
==========================================
Files 189 189
Lines 11732 11732
Branches 1046 1046
==========================================
+ Hits 5529 5530 +1
Misses 5833 5833
+ Partials 370 369 -1 ☔ View full report in Codecov by Sentry. |
| activeMapPartitions = JavaUtils.newConcurrentHashMap(); | ||
| this.minReadBuffers = minReadBuffers; | ||
| this.maxReadBuffers = maxReadBuffers; | ||
| threadsPerMountPoint = threadsPerMountpoint; |
There was a problem hiding this comment.
We just use different variable names here to avoid this problem.
https://errorprone.info/bugpattern/InconsistentCapitalization
|
I have a question that the maven build system will be dropped after v0.5.0 or later. Is this necessary? Will error prone be integrated into SBT? |
A JIRA ticket has been created to track this issue. CELEBORN-1080 Tried it locally but not successful yet. |
|
IMO, it would be better to hold this PR until there is a solution to add the error-prone plugin into SBT. |
Hi @FMX , I think we don't require this PR to also support SBT before merging. It's totally OK to do it in future. |
cxzl25
force-pushed
the
error_prone_patch_followup
branch
from
e828e67 to
aa26ee9
Compare
…roblems 1. Fix IntLongMath, InconsistentCapitalization, UnnecessaryAssignment 2. disable StringSplitter, EmptyBlockTag, EqualsGetClass, MissingSummary, BadImport No GA ```bash ./build/make-distribution.sh --release ``` PR total 202 ``` 43 SynchronizeOnNonFinalField 24 StaticAssignmentInConstructor 21 JdkObsolete 16 ThreadLocalUsage 16 MutableConstantField 16 MissingCasesInEnumSwitch 11 UnusedMethod 11 NonAtomicVolatileUpdate 8 UnusedNestedClass 8 NonOverridingEquals 8 Finally 4 MixedMutabilityReturnType 4 DoubleBraceInitialization 4 CatchAndPrintStackTrace 4 CanonicalDuration 2 ReferenceEquality 1 ClassCanBeStatic 1 ByteBufferBackingArray ``` Closes #2180 from cxzl25/error_prone_patch_followup. Authored-by: sychen <sychen@ctrip.com> Signed-off-by: zky.zhoukeyong <zky.zhoukeyong@alibaba-inc.com>
5 participants
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
GA
PR
total 202