Skip to content

[CELEBORN-1190][FOLLOWUP] Update WARNING checks of error prone to ERROR for CI#2649

Closed
SteNicholas wants to merge 1 commit intoapache:mainfrom
SteNicholas:CELEBORN-1190
Closed

[CELEBORN-1190][FOLLOWUP] Update WARNING checks of error prone to ERROR for CI#2649
SteNicholas wants to merge 1 commit intoapache:mainfrom
SteNicholas:CELEBORN-1190

Conversation

@SteNicholas
Copy link
Member

What changes were proposed in this pull request?

Update WARNING checks of error prone to ERROR for CI.

Follow up #2177, #2180, #2555.

Why are the changes needed?

Error prone generates some WARNING in complication, which has been fixed in #2177, #2180, #2555. Therefore, the following WARNING checks should be updated to ERROR for CI, which rules are supported in error prone 2.10.0 and 2.25.0:

  • AssertThrowsMultipleStatements
  • ByteBufferBackingArray
  • CacheLoaderNull
  • CanonicalDuration
  • ClassCanBeStatic
  • DefaultCharset
  • InconsistentCapitalization
  • IntLongMath
  • InvalidParam
  • JavaUtilDateChecker
  • MissingCasesInEnumSwitch
  • MissingOverride
  • NonAtomicVolatileUpdate
  • StaticAssignmentInConstructor
  • SynchronizeOnNonFinalField
  • ThreadLocalUsage
  • UnescapedEntity
  • UnnecessaryAssignment
  • UnusedMethod
  • UnusedNestedClass
  • UseCorrectAssertInTests

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant