[CELEBORN-1462] Fix layout of DeviceCelebornTotalBytes, DeviceCelebornFreeBytes, RunningApplicationCount and DecommissionWorkerCount in celeborn-dashboard.json#2569
Closed
SteNicholas wants to merge 1 commit intoapache:mainfrom
Conversation
…nFreeBytes, RunningApplicationCount and DecommissionWorkerCount in celeborn-dashboard.json
Member
Author
RexXiong
approved these changes
Jun 14, 2024
FMX
approved these changes
Jun 14, 2024
Contributor
FMX
left a comment
FMX
left a comment
There was a problem hiding this comment.
LGTM. Merged into main(v0.6.0) and branch-0.5(v0.5.1).
FMX
pushed a commit
that referenced
this pull request
Jun 14, 2024
…nFreeBytes, RunningApplicationCount and DecommissionWorkerCount in celeborn-dashboard.json ### What changes were proposed in this pull request? Fix layout of `DeviceCelebornTotalBytes`, `DeviceCelebornFreeBytes`, `RunningApplicationCount` and `DecommissionWorkerCount` in `celeborn-dashboard.json`. ### Why are the changes needed? The layout of `DeviceCelebornTotalBytes`, `DeviceCelebornFreeBytes`, `RunningApplicationCount` and `DecommissionWorkerCount` in `celeborn-dashboard.json` have wrong position as follows:  We should fix the correct position to provide layout of `DeviceCelebornTotalBytes`, `DeviceCelebornFreeBytes`, `RunningApplicationCount` and `DecommissionWorkerCount`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual test: [Celeborn Grafana Dashboard](https://stenicholas.grafana.net/public-dashboards/822b08768a324dfe9fc526254bae5ae5). Closes #2569 from SteNicholas/CELEBORN-1462. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com> (cherry picked from commit f63ff34) Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix layout of
DeviceCelebornTotalBytes,DeviceCelebornFreeBytes,RunningApplicationCountandDecommissionWorkerCountinceleborn-dashboard.json.Why are the changes needed?
The layout of
DeviceCelebornTotalBytes,DeviceCelebornFreeBytes,RunningApplicationCountandDecommissionWorkerCountinceleborn-dashboard.jsonhave wrong position as follows:We should fix the correct position to provide layout of
DeviceCelebornTotalBytes,DeviceCelebornFreeBytes,RunningApplicationCountandDecommissionWorkerCount.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual test: Celeborn Grafana Dashboard.