[CELEBORN-1665][0.5] CommitHandler should process CommitFilesResponse with COMMIT_FILE_EXCEPTION status#2840
Closed
SteNicholas wants to merge 1 commit into
Closed
Conversation
… COMMIT_FILE_EXCEPTION status
SteNicholas
added a commit
that referenced
this pull request
Oct 22, 2024
… with COMMIT_FILE_EXCEPTION status ### What changes were proposed in this pull request? `CommitHandler` should process `CommitFilesResponse` with `COMMIT_FILE_EXCEPTION` status. ### Why are the changes needed? `CommitHandler` processes `CommitFilesResponse` with statuses including `SUCCESS`, `PARTIAL_SUCCESS`, `SHUFFLE_NOT_REGISTERED`, `REQUEST_FAILED` and `WORKER_EXCLUDED` at present. Meanwhile, Controller replies `CommitFilesResponse` with `COMMIT_FILE_EXCEPTION` status for throwable. Therefore, `CommitHandler` should process `COMMIT_FILE_EXCEPTION` status. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No. Closes #2840 from SteNicholas/CELEBORN-1665-0.5. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: SteNicholas <programgeek@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
CommitHandlershould processCommitFilesResponsewithCOMMIT_FILE_EXCEPTIONstatus.Why are the changes needed?
CommitHandlerprocessesCommitFilesResponsewith statuses includingSUCCESS,PARTIAL_SUCCESS,SHUFFLE_NOT_REGISTERED,REQUEST_FAILEDandWORKER_EXCLUDEDat present. Meanwhile, Controller repliesCommitFilesResponsewithCOMMIT_FILE_EXCEPTIONstatus for throwable. Therefore,CommitHandlershould processCOMMIT_FILE_EXCEPTIONstatus.Does this PR introduce any user-facing change?
No.
How was this patch tested?
No.