Skip to content

[CELEBORN-1665][0.5] CommitHandler should process CommitFilesResponse with COMMIT_FILE_EXCEPTION status #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SteNicholas wants to merge 1 commit into from
Closed

[CELEBORN-1665][0.5] CommitHandler should process CommitFilesResponse with COMMIT_FILE_EXCEPTION status #2840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/main/scala/org/apache/celeborn/client/commit/CommitHandler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ abstract class CommitHandler(
status.future.value.get match {
case scala.util.Success(res) =>
res.status match {
case StatusCode.SUCCESS | StatusCode.PARTIAL_SUCCESS | StatusCode.SHUFFLE_NOT_REGISTERED | StatusCode.REQUEST_FAILED | StatusCode.WORKER_EXCLUDED =>
case StatusCode.SUCCESS | StatusCode.PARTIAL_SUCCESS | StatusCode.SHUFFLE_NOT_REGISTERED | StatusCode.REQUEST_FAILED | StatusCode.WORKER_EXCLUDED | StatusCode.COMMIT_FILE_EXCEPTION =>
logInfo(s"Request commitFiles return ${res.status} for " +
s"${Utils.makeShuffleKey(appUniqueId, shuffleId)}")
if (res.status != StatusCode.SUCCESS && res.status != StatusCode.WORKER_EXCLUDED) {
Expand Down
16 changes: 16 additions & 0 deletions common/src/main/scala/org/apache/celeborn/common/util/Utils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,10 +1070,24 @@ object Utils extends Logging {
StatusCode.WORKER_EXCLUDED
case 28 =>
StatusCode.WORKER_UNKNOWN
case 29 =>
StatusCode.COMMIT_FILE_EXCEPTION
case 30 =>
StatusCode.PUSH_DATA_SUCCESS_PRIMARY_CONGESTED
case 31 =>
StatusCode.PUSH_DATA_SUCCESS_REPLICA_CONGESTED
case 32 =>
StatusCode.PUSH_DATA_HANDSHAKE_FAIL_REPLICA
case 33 =>
StatusCode.PUSH_DATA_HANDSHAKE_FAIL_PRIMARY
case 34 =>
StatusCode.REGION_START_FAIL_REPLICA
case 35 =>
StatusCode.REGION_START_FAIL_PRIMARY
case 36 =>
StatusCode.REGION_FINISH_FAIL_REPLICA
case 37 =>
StatusCode.REGION_FINISH_FAIL_PRIMARY
case 38 =>
StatusCode.PUSH_DATA_CREATE_CONNECTION_FAIL_PRIMARY
case 39 =>
Expand All @@ -1100,6 +1114,8 @@ object Utils extends Logging {
StatusCode.COMMIT_FILES_MOCK_FAILURE
case 50 =>
StatusCode.PUSH_DATA_FAIL_NON_CRITICAL_CAUSE_REPLICA
case 51 =>
StatusCode.OPEN_STREAM_FAILED
case _ =>
null
}
Expand Down