[CELEBORN-1516][FOLLOWUP] Support reset method for DynamicConfigServiceFactory#2848
Closed
s0nskar wants to merge 2 commits intoapache:mainfrom
Closed
[CELEBORN-1516][FOLLOWUP] Support reset method for DynamicConfigServiceFactory#2848s0nskar wants to merge 2 commits intoapache:mainfrom
s0nskar wants to merge 2 commits intoapache:mainfrom
Conversation
s0nskar
changed the title
Contributor
Author
|
cc: @SteNicholas @leixm PTAL |
Contributor
Author
RexXiong
reviewed
Oct 29, 2024
|
|
||
| @VisibleForTesting | ||
| public static void reset() { | ||
| _INSTANCE = null; |
Contributor
There was a problem hiding this comment.
Need call shutdown method before reset the _INSTANCE
Contributor
Author
|
Can we please merge this, this is blocking another PR - #2844 |
Contributor
Sure, merge to main(v0.6.0) and branch-0.5(v0.5.3) |
RexXiong
pushed a commit
that referenced
this pull request
Oct 30, 2024
…ceFactory ### What changes were proposed in this pull request? - Added a reset method for DynamicConfigServiceFactory - Cleaned up QuotaManagerSuite ### Why are the changes needed? Without this change we can not initialize new configService in any other tests. Ex: test for this PR #2844 are failing because of this issue. ### Does this PR introduce _any_ user-facing change? NA ### How was this patch tested? NA Closes #2848 from s0nskar/fix_quotatest. Authored-by: Sanskar Modi <sanskarmodi97@gmail.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com> (cherry picked from commit 752a0d9) Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
Contributor
Author
|
Thanks @RexXiong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Without this change we can not initialize new configService in any other tests.
Ex: test for this PR #2844 are failing because of this issue.
Does this PR introduce any user-facing change?
NA
How was this patch tested?
NA