[CELEBORN-1619][CIP-11] Integrate tags manager with config service#2844
Closed
s0nskar wants to merge 6 commits intoapache:mainfrom
Closed
[CELEBORN-1619][CIP-11] Integrate tags manager with config service#2844s0nskar wants to merge 6 commits intoapache:mainfrom
s0nskar wants to merge 6 commits intoapache:mainfrom
Conversation
RexXiong
pushed a commit
that referenced
this pull request
Oct 30, 2024
…ceFactory ### What changes were proposed in this pull request? - Added a reset method for DynamicConfigServiceFactory - Cleaned up QuotaManagerSuite ### Why are the changes needed? Without this change we can not initialize new configService in any other tests. Ex: test for this PR #2844 are failing because of this issue. ### Does this PR introduce _any_ user-facing change? NA ### How was this patch tested? NA Closes #2848 from s0nskar/fix_quotatest. Authored-by: Sanskar Modi <sanskarmodi97@gmail.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
RexXiong
pushed a commit
that referenced
this pull request
Oct 30, 2024
…ceFactory ### What changes were proposed in this pull request? - Added a reset method for DynamicConfigServiceFactory - Cleaned up QuotaManagerSuite ### Why are the changes needed? Without this change we can not initialize new configService in any other tests. Ex: test for this PR #2844 are failing because of this issue. ### Does this PR introduce _any_ user-facing change? NA ### How was this patch tested? NA Closes #2848 from s0nskar/fix_quotatest. Authored-by: Sanskar Modi <sanskarmodi97@gmail.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com> (cherry picked from commit 752a0d9) Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
s0nskar
force-pushed
the
tags_via_config
branch
from
9e1f190 to
56b3617
Compare
Contributor
Author
|
cc: @FMX PTAL |
Contributor
Author
|
@FMX ping on this. |
Contributor
Author
|
ping @FMX @zwangsheng @mridulm for review |
Contributor
|
Sorry for the delayed response, I'll review this PR tomorrow. |
FMX
approved these changes
Nov 13, 2024
Contributor
FMX
left a comment
FMX
left a comment
There was a problem hiding this comment.
LGTM except for a nit. There will likely be more PRs to finish this feature. Thanks.
Contributor
Author
@FMX Addressed. Yes, there will be couple more PRs. |
Contributor
|
Thanks. Merged into main(v0.6.0). |
SteNicholas
added a commit
that referenced
this pull request
Nov 18, 2024
…wConcurrentHashMap to speed up ConcurrentHashMap#computeIfAbsent ### What changes were proposed in this pull request? `TagsManager` uses `JavaUtils#newConcurrentHashMap` to speed up `ConcurrentHashMap#computeIfAbsent`. Follow up #2844. ### Why are the changes needed? Celeborn supports JDK8, which could meet the bug mentioned in [JDK-8161372](https://bugs.openjdk.org/browse/JDK-8161372). Therefore, it's better to use `JavaUtils#newConcurrentHashMap` to speed up `ConcurrentHashMap#computeIfAbsent`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. Closes #2922 from SteNicholas/CELEBORN-1619. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: SteNicholas <programgeek@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Integrating TagsManager with configService. Users can now update the workers tags using ConfigService.
Why are the changes needed?
https://cwiki.apache.org/confluence/display/CELEBORN/CIP-11+Supporting+Tags+in+Celeborn
Does this PR introduce any user-facing change?
NA
How was this patch tested?
UTs