[CELEBORN-1619][CELEBORN-474][FOLLOWUP] TagsManager uses JavaUtils#newConcurrentHashMap to speed up ConcurrentHashMap#computeIfAbsent#2922
Closed
SteNicholas wants to merge 1 commit intoapache:mainfrom
Closed
Conversation
…wConcurrentHashMap to speed up ConcurrentHashMap#computeIfAbsent
s0nskar
approved these changes
Nov 15, 2024
Contributor
s0nskar
left a comment
s0nskar
left a comment
There was a problem hiding this comment.
LGTM! Thanks @SteNicholas
Member
Author
|
Ping @turboFei. |
turboFei
approved these changes
Nov 15, 2024
Member
Author
|
Merged to main(v0.6.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TagsManagerusesJavaUtils#newConcurrentHashMapto speed upConcurrentHashMap#computeIfAbsent.Follow up #2844.
Why are the changes needed?
Celeborn supports JDK8, which could meet the bug mentioned in JDK-8161372. Therefore, it's better to use
JavaUtils#newConcurrentHashMapto speed upConcurrentHashMap#computeIfAbsent.Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.