[CELEBORN-XXXX] Expose manually excluded worker count metric - #3772
Closed
tashi-rokt wants to merge 1 commit into
Closed
[CELEBORN-XXXX] Expose manually excluded worker count metric#3772tashi-rokt wants to merge 1 commit into
tashi-rokt wants to merge 1 commit into
Conversation
Kalvin2077
approved these changes
Jul 29, 2026
Contributor
|
@tashi-rokt |
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This issue was closed because it has been staled for 10 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a
ManualExcludedWorkerCountmaster gauge that reports only workers excluded through the manual exclusion mechanism.The existing
ExcludedWorkerCountremains unchanged and continues to report the combined automatic and manual exclusion count. The new gauge is also documented in the master metrics reference.Why are the changes needed?
ExcludedWorkerCountcombines automatic and manual exclusions, so operators cannot determine from metrics whether persistent manual exclusion state is preventing otherwise healthy workers from becoming available.The REST API exposes the two states separately, but diagnosing this condition currently requires querying the active master. Exporting the manual count separately makes the distinction observable through the existing metrics system without changing exclusion behavior.
Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?
MasterSuitetest that verifies the emitted gauge follows manual exclusion state from 0 to 1 and back to 0../build/mvn -pl master -am -Dtest=none -DwildcardSuites=org.apache.celeborn.service.deploy.master.MasterSuite test./build/mvn spotless:check -Pgoogle-mirror,spark-3.3Both commands passed locally.
Draft note
The CELEBORN Jira is still to be created. Replace
CELEBORN-XXXXin the title and link the Jira before marking this PR ready for review.