[CELEBORN-2396][CLI] Fix CelebornCli.main discarding the configured CommandLine instance - #3773
Closed
yew1eb wants to merge 3 commits into
Closed
[CELEBORN-2396][CLI] Fix CelebornCli.main discarding the configured CommandLine instance#3773yew1eb wants to merge 3 commits into
yew1eb wants to merge 3 commits into
Conversation
Kalvin2077
approved these changes
Jul 30, 2026
RexXiong
approved these changes
Jul 30, 2026
SteNicholas
pushed a commit
that referenced
this pull request
Aug 3, 2026
…ommandLine instance ### What changes were proposed in this pull request? Call `execute()` on the configured `CommandLine` instance instead of creating and executing a new one. ### Why are the changes needed? `CelebornCli.main` creates a `CommandLine`, sets case-sensitivity options on it, but then executes a brand-new instance, so the configuration is silently discarded and the two setter calls are dead code. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Closes #3773 from yew1eb/CELEBORN-2396. Authored-by: yew1eb <yew1eb@gmail.com> Signed-off-by: Nicholas Jiang <programgeek@163.com> (cherry picked from commit fd6aaa5) Signed-off-by: Nicholas Jiang <programgeek@163.com>
Member
|
Thanks. Merged to main(v1.0.0) and branch-0.7(v0.7.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Call
execute()on the configuredCommandLineinstance instead of creating and executing a new one.Why are the changes needed?
CelebornCli.maincreates aCommandLine, sets case-sensitivity options on it, but then executes a brand-new instance, so the configuration is silently discarded and the two setter calls are dead code.Does this PR introduce any user-facing change?
No.
How was this patch tested?