[CELEBORN-2404] Fix required field typo in SendWorkerEventRequest schema - #3783
Merged
zaynt4606 merged 2 commits intoAug 6, 2026
Merged
Conversation
cxzl25
approved these changes
Aug 5, 2026
SteNicholas
requested changes
Aug 5, 2026
Member
There was a problem hiding this comment.
@yew1eb, please fix the failure of openapi-codegen-check.
Kalvin2077
approved these changes
Aug 6, 2026
Contributor
Author
@SteNicholas Fixed. |
Contributor
|
@zaynt4606 We need to use |
SteNicholas
pushed a commit
that referenced
this pull request
Aug 6, 2026
### What changes were proposed in this pull request? Fix a typo in `master_rest_v1.yaml`: the `SendWorkerEventRequest` schema declared `worker` in its `required` list, but the actual property name is `workers`. ### Why are the changes needed? The openapi-generator silently ignores the non-existent `worker` field, so the generated client compiles fine, but the spec declares a required field that does not exist and Swagger UI misleadingly shows `worker` as required. The server side validates `request.getWorkers.isEmpty`, consistent with the `workers` property. ### Does this PR resolve a correctness bug? - [ ] Yes ### Does this PR introduce _any_ user-facing change? - [ ] Yes ### How was this patch tested? - Regenerated the openapi client (`./build/mvn clean generate-sources -pl openapi/openapi-client`): no diff in generated code, as the generator does not emit anything for `required`. - The module builds successfully, which also validates the YAML syntax. Closes #3783 from yew1eb/fix-send-worker-event-request-required. Authored-by: yew1eb <yew1eb@gmail.com> Signed-off-by: Nicholas Jiang <programgeek@163.com>
SteNicholas
pushed a commit
that referenced
this pull request
Aug 6, 2026
### What changes were proposed in this pull request? Fix a typo in `master_rest_v1.yaml`: the `SendWorkerEventRequest` schema declared `worker` in its `required` list, but the actual property name is `workers`. ### Why are the changes needed? The openapi-generator silently ignores the non-existent `worker` field, so the generated client compiles fine, but the spec declares a required field that does not exist and Swagger UI misleadingly shows `worker` as required. The server side validates `request.getWorkers.isEmpty`, consistent with the `workers` property. ### Does this PR resolve a correctness bug? - [ ] Yes ### Does this PR introduce _any_ user-facing change? - [ ] Yes ### How was this patch tested? - Regenerated the openapi client (`./build/mvn clean generate-sources -pl openapi/openapi-client`): no diff in generated code, as the generator does not emit anything for `required`. - The module builds successfully, which also validates the YAML syntax. Closes #3783 from yew1eb/fix-send-worker-event-request-required. Authored-by: yew1eb <yew1eb@gmail.com> Signed-off-by: Nicholas Jiang <programgeek@163.com> (cherry picked from commit c0cad19) Signed-off-by: Nicholas Jiang <programgeek@163.com>
Member
|
Thanks. Merged to main(v1.0.0) and branch-0.7(v0.7.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix a typo in
master_rest_v1.yaml: theSendWorkerEventRequestschema declaredworkerin itsrequiredlist, but the actual property name isworkers.Why are the changes needed?
The openapi-generator silently ignores the non-existent
workerfield, so the generated client compiles fine, but the spec declares a required field that does not exist and Swagger UI misleadingly showsworkeras required. The server side validatesrequest.getWorkers.isEmpty, consistent with theworkersproperty.Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?
./build/mvn clean generate-sources -pl openapi/openapi-client): no diff in generated code, as the generator does not emit anything forrequired.