Feature/cpp17 promise - #272
Merged
Merged
Conversation
Contributor
|
Any idea why the builds are failing? |
pnoltes
reviewed
Jul 20, 2020
| ) | ||
| target_link_libraries(Promise INTERFACE TBB::tbb Threads::Threads) | ||
| target_compile_options(Promise INTERFACE -frtti) #Note needed for TBB | ||
| target_compile_options(Promise INTERFACE -frtti -std=c++17) #Note needed for TBB |
Contributor
There was a problem hiding this comment.
The note, is only for -frtti not c++17
pnoltes
approved these changes
Aug 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are based on #270, which explain the duplicate changes. Once #270 is merged, the diff will be 'nicer'.
The most important change is to use std::optional instead of placement new/buffer.