Skip to content

Bump log4j to 2.25.4#121

Merged
MisterRaindrop merged 1 commit into
apache:mainfrom
Sanikadze:bump-log4j-2.25.4
Jul 1, 2026
Merged

Bump log4j to 2.25.4#121
MisterRaindrop merged 1 commit into
apache:mainfrom
Sanikadze:bump-log4j-2.25.4

Conversation

@Sanikadze

Copy link
Copy Markdown
Contributor

Summary

Bump log4j from 2.17.2 to 2.25.4. Closes CVE-2026-34480 (XmlLayout invalid XML output) and CVE-2026-34477 (SSL hostname verification bypass).

Changes

server/build.gradle

  • Add ext['log4j2.version'] = '2.25.4' so the version managed by the imported spring-boot-dependencies BOM (which pins log4j-bom 2.17.2) is overridden. A bomProperty override does not reach the nested log4j-bom, hence the explicit ext property.
  • Replace the log4j-spring-boot:2.17.2 pin (and its junit excludes) with log4j-spring-boot:2.25.4. The excludes were a workaround for junit leaking into compileClasspath in 2.17.2; this was fixed upstream in 2.19.0, so at 2.25.4 they are dead code (the old comment said to remove them on upgrade).

server/pxf-service/build.gradle

  • Add an explicit commons-logging dependency. log4j-spring-boot 2.25.4 no longer pulls it transitively, so without this it drops out of the jar.

Verification

  • Build and tests are green. ./gradlew :pxf-api:test :pxf-service:teston JDK 8 — BUILD SUCCESSFUL, 679 tests, 678 passed, 0 failed, 1 skipped.api/core/jul/spring-boot, with no junit leaked into the jar and commons-logging-1.1.3 present.
  • Logging is healthy at runtime. pxf-service.log is written with the expected Log4j2 layout, with zero StatusLogger init errors and no log4j config errors;

Signed-off-by: Sanikadze <kavun.alexsander@gmail.com>
@ostinru
ostinru self-requested a review June 28, 2026 15:14
@ostinru ostinru added the dependencies Pull requests that update a dependency file label Jun 28, 2026
@Sanikadze

Copy link
Copy Markdown
Contributor Author

The failing checks are unrelated to this change.

Everything that actually exercises this log4j bump is green.

@ostinru

ostinru commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

The failing checks are unrelated to this change.

Thats right. There are some issues with Hadoop tests on Rocky linux.

PS: review for this PR is in my pipeline. However I am quite busy these days.

@tuhaihe
tuhaihe requested a review from MisterRaindrop July 1, 2026 07:52

@MisterRaindrop MisterRaindrop left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MisterRaindrop
MisterRaindrop merged commit 75cf1f6 into apache:main Jul 1, 2026
103 of 115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants