Explicit dependencies in pxf-hdfs#122
Merged
Merged
Conversation
ostinru
marked this pull request as ready for review
July 7, 2026 11:58
MisterRaindrop
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just found out that in our fork (legacy-pxf) we have broken dependences. I was curious why we don't seen an issue in tests. And, I realised that
parquet-pigtransitively pulls couple compressors to testRuntimeClasspath and hides the fact that pxf-hdfs doesn't have snappy (and zstd in my fork) as direct runtime dependency.So, this PR removes transitive test-dependencies and explicitly adds runtime dependencies