Skip to content

Enhance cloudstack_disk_offering resource and datasource#301

Open
bddvlpr wants to merge 2 commits into
apache:mainfrom
bddvlpr:feat/disk-offering
Open

Enhance cloudstack_disk_offering resource and datasource#301
bddvlpr wants to merge 2 commits into
apache:mainfrom
bddvlpr:feat/disk-offering

Conversation

@bddvlpr

@bddvlpr bddvlpr commented Jul 9, 2026

Copy link
Copy Markdown

Adds a bunch of missing parameters to the disk offering resource. Initialized the data source for it while I was at it.

Tested on simulator.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the cloudstack_disk_offering Terraform resource to support additional CloudStack disk-offering parameters and completes the CRUD implementation, while also introducing a new cloudstack_disk_offering data source (plus docs and acceptance tests) so disk offerings can be discovered and referenced by other resources.

Changes:

  • Expanded cloudstack_disk_offering resource schema (custom sizing, storage/provisioning type, tags, display flag) and implemented Read/Update/Delete + Importer.
  • Added cloudstack_disk_offering data source with filter-based selection and acceptance tests.
  • Updated/added website documentation for the resource and data source.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
website/docs/r/disk_offering.html.markdown Documents the expanded disk offering resource arguments and attributes.
website/docs/d/disk_offering.html.markdown Adds documentation for the new disk offering data source.
cloudstack/resource_cloudstack_disk_offering.go Implements full disk offering resource CRUD/import and adds missing schema parameters.
cloudstack/resource_cloudstack_disk_offering_test.go Adds acceptance tests for disk offering resource scenarios (basic/customized/update).
cloudstack/provider.go Registers the new disk offering data source with the provider.
cloudstack/data_source_cloudstack_disk_offering.go Implements the disk offering data source and filter logic.
cloudstack/data_source_cloudstack_disk_offering_test.go Adds an acceptance test validating the disk offering data source against a created resource.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cloudstack/resource_cloudstack_disk_offering.go
Comment thread website/docs/r/disk_offering.html.markdown Outdated
Comment thread cloudstack/data_source_cloudstack_disk_offering.go
Comment thread cloudstack/resource_cloudstack_disk_offering_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants