Performance improvements of AgentPropertiesFileHandler - #13852
Open
sureshanaparti wants to merge 1 commit into
Open
Performance improvements of AgentPropertiesFileHandler#13852sureshanaparti wants to merge 1 commit into
sureshanaparti wants to merge 1 commit into
Conversation
sureshanaparti
force-pushed
the
agent-properties-handler-improvements
branch
from
August 11, 2026 14:59
26e4af3 to
53f7168
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #13852 +/- ##
=========================================
Coverage 17.69% 17.70%
- Complexity 15835 15841 +6
=========================================
Files 5925 5925
Lines 533539 533572 +33
Branches 65274 65277 +3
=========================================
+ Hits 94427 94450 +23
- Misses 428435 428444 +9
- Partials 10677 10678 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DaanHoogland
left a comment
DaanHoogland
left a comment
Contributor
There was a problem hiding this comment.
not sure about the failure handling.
| LOGGER.info("Loaded {} properties from [{}]", newProperties.size(), agentPropertiesFile.getAbsolutePath()); | ||
|
|
||
| } catch (IOException ex) { | ||
| LOGGER.error("Failed to load properties from file [{}].", agentPropertiesFile.getAbsolutePath(), ex); |
Contributor
There was a problem hiding this comment.
this seems FATAL to me. Any reason to keep running when this occurs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the AgentPropertiesFileHandler.getPropertyValue method. This method is used to fetch properties values from agent.properties file. In the proposed change, the properties file is loaded lazily on first access and cached. The cache is invalidated whenever the agent persists a change via PropertiesStorage.persist, so agent-driven updates are picked up on the next read. External manual edits to agent.properties are not auto-detected and take effect after an agent restart.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?