Add missing Java 9 and Java 11 class file attributes.#33
Merged
garydgregory merged 5 commits intoapache:masterfrom Aug 27, 2019
markro49:java9
Merged
Add missing Java 9 and Java 11 class file attributes.#33garydgregory merged 5 commits intoapache:masterfrom markro49:java9
garydgregory merged 5 commits intoapache:masterfrom
markro49:java9
Conversation
Contributor
Author
|
working on java 11 failures |
garydgregory
requested changes
Aug 26, 2019
| /** | ||
| * @since 6.0 | ||
| */ | ||
| void visitMethodParameter(MethodParameter obj); |
Member
There was a problem hiding this comment.
Hi @markro49,
New methods in interfaces must be added as Java 8 default methods in order for us to maintain binary compatibility. Also the @since should be for 6.4.0, not 6.0.
Gary
Contributor
Author
There was a problem hiding this comment.
I understand the compatibility requirement, but I am unsure of what it means to make them a Java 8 default method.
Member
There was a problem hiding this comment.
Supply default visitMethodParameter implementation for Visitor interface.
asfgit
pushed a commit
that referenced
this pull request
Aug 27, 2019
Use @SInCE 6.4.0 instead of 6.4.
asfgit
pushed a commit
that referenced
this pull request
Aug 27, 2019
7 tasks
Raygama
referenced
this pull request
in Raygama/bcel-demo
Aug 30, 2025
"Add missing Java 9 and Java 11 class file attributes. (#33) * Add missing Java 9 and Java 11 class file attributes. * update for newer attributes * add missing visitor needed by java 11 * Correct version number comments. Supply default visitMethodParameter implementation for Visitor interface."
7 tasks
Raygama
referenced
this pull request
in Raygama/bcel-demo
Sep 18, 2025
"Add missing Java 9 and Java 11 class file attributes. (#33) * Add missing Java 9 and Java 11 class file attributes. * update for newer attributes * add missing visitor needed by java 11 * Correct version number comments. Supply default visitMethodParameter implementation for Visitor interface."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for several class file attributes added for Java 9 and Java 11. At some point, may wish to add additional getters and setters. Current level of support is enough to read, write and display all fields of each attribute.
Also did some work to make the various attribute toString() methods produce similarly formatted output.
This pull request is in response to https://issues.apache.org/jira/browse/BCEL-325. In addition to adding support for the missing attributes, it fixes a problem building and running on Java 9.