Fix ConstantPoolGen dedup key collisions for names with delimiters#510
Merged
garydgregory merged 1 commit intoJul 2, 2026
Merged
Conversation
Class and member names may legally contain the ':', '#', '&' and '%' characters used to delimit the constant pool dedup-table keys, so two distinct references whose names contain one collapsed to a single constant pool entry. Length-prefix each key part so distinct triples stay distinct.
garydgregory
added a commit
that referenced
this pull request
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConstantPoolGendedups field/method/interface-method refs in onecpTable(and name-and-type entries innatTable) by concatenating the class, member and signature names with single-char delimiters (:#&%). Those characters are legal inside JVM names, JVMS 4.2.2 only bans. ; [ /and, for members,< >, so two distinct refs whose names contain a delimiter hash to the same key. Spotted while auditing the dedup tables:addMethodref("Foo", "bar:baz", "()V")andaddMethodref("Foo:bar", "baz", "()V")both build the keyFoo:bar:baz:()V, so the secondadd/lookupreturns the first ref's constant pool index and an instruction emitted against it points at the wrong member when a pool is rebuilt from an untrusted class.Route every
cpTable/natTablekey through atoKeyhelper that length-prefixes each part, so the key stays uniquely decodable whatever the parts contain. Keeping the keying in one private helper means add and lookup can't drift apart, and there is no public API change.mvn; that'smvnon the command line by itself.